mirror of
https://github.com/apache/impala.git
synced 2025-12-25 02:03:09 -05:00
f0a781806f
Catalogd logs of GetPartialCatalogObject requests are not tagged with correct query ids. Instead, the query id that is previously using that thread is printed in the logs. This is fixed by using ScopedThreadContext which resets the query id at the end of the RPC code. Add DCHECKs to make sure ThreadDebugInfo is initialized before being used in Catalog methods. An instance is added in CatalogdMain() for this. This patch also adds the query id in GetPartialCatalogObject requests so catalogd can tag the responding thread with it. Some codes are copied from Michael Smith's patch: https://gerrit.cloudera.org/c/22738/ Tested by enabling TRACE logging in org.apache.impala.common.JniUtil to verify logs of GetPartialCatalogObject requests. I20251014 09:39:39.685225 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID I20251014 09:39:39.690346 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of CATALOG_SERVICE_ID. Time spent: 5ms I20251014 09:39:39.699471 342587 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional I20251014 09:39:39.701821 342587 JniUtil.java:176] 964e37e9303d6f8a:eab7096000000000] Finished getPartialCatalogObject request: Getting partial catalog object of DATABASE:functional. Time spent: 2ms I20251014 09:39:39.711462 341074 TAcceptQueueServer.cpp:368] New connection to server CatalogService from client <Host: 127.0.0.1 Port: 42084> I20251014 09:39:39.719146 342588 JniUtil.java:165] 964e37e9303d6f8a:eab7096000000000] getPartialCatalogObject request: Getting partial catalog object of TABLE:functional.alltypestiny Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674 Reviewed-on: http://gerrit.cloudera.org:8080/23535 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>