mirror of
https://github.com/apache/impala.git
synced 2025-12-23 21:08:39 -05:00
Before this patch Impala mainly used Thrift 0.9.3, but it was
possible to compile Impala shell with Thrift 0.11.0, so the 0.11.0
Thrift lib was already included in the toolchain.
Most of the changes are related to replacing boost:: with std::
shared_ptr-s in cpp code (this is a continuation of patch by Sahil).
The Thrift upgrade also needs an Impyla release with Thrift 0.11.0, as
Impala's test framework relies on Impyla. A thrift_sasl release is also
needed, because it currently pins Thrift version to 0.9.3 for Python 2.
The current patch uses alpha releases from Impyla and thrift_sasl that
use thrift 0.11.0.
Notable side effects:
- old logic to compile thrift for impala-shell with 0.11.0 was removed
- impala_shell's utf8 handling had to be updated as the new 0.11.0
compilation happens with no_utf8strings. This also made things a
bit faster, e.g the following is ~0.22s instead of ~0.25
shell/impala_shell.py \
-B -q "select * from functional_parquet.alltypes;" > /dev/null
- THRIFT-3921 changed the stream operators to print an enum's name
instead of its number, leading to slightly different messages
in some cases.
- "templates" was added to the thift generator's parameters to avoid
a compilation issue (related to IMPALA-10600). I didn't notice any
change in compilation time. This option generated .tcc files with
templetized readers/writers for Thrift types. Currently we don't
use these, but they could potentially speed up (de)serialization.
Testing:
- ran Impyla's test suite with Python 2 and 3
- ran core tests
Change-Id: Idd13f177b4f7acc07872ea6399035aa180ef6ab6
Reviewed-on: http://gerrit.cloudera.org:8080/17170
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
163 lines
6.0 KiB
Bash
Executable File
163 lines
6.0 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
# This script makes a tarball of the Python-based shell that can be unzipped and
|
|
# run out-of-the-box with no configuration. The final tarball is left in
|
|
# ${IMPALA_HOME}/shell/build.
|
|
|
|
set -euo pipefail
|
|
. $IMPALA_HOME/bin/report_build_error.sh
|
|
setup_report_build_error
|
|
|
|
if [ "x${IMPALA_HOME}" == "x" ]; then
|
|
echo "\$IMPALA_HOME must be set"
|
|
exit 1
|
|
fi
|
|
|
|
# Detect whether IMPALA_HOME is a git repository. This is used below to allow extra
|
|
# checks when building ext-py.
|
|
pushd ${IMPALA_HOME}
|
|
IS_GIT_CHECKOUT=false
|
|
if git ls-files --error-unmatch > /dev/null 2>&1 ; then
|
|
IS_GIT_CHECKOUT=true
|
|
echo "IMPALA_HOME is a git repository"
|
|
else
|
|
echo "IMPALA_HOME is not a git repository"
|
|
fi;
|
|
popd
|
|
|
|
IMPALA_VERSION_INFO_FILE=${IMPALA_HOME}/bin/version.info
|
|
|
|
if [ ! -f ${IMPALA_VERSION_INFO_FILE} ]; then
|
|
echo "No version.info file found. Generating new version info"
|
|
${IMPALA_HOME}/bin/save-version.sh
|
|
else
|
|
echo "Using existing version.info file."
|
|
fi
|
|
|
|
VERSION=$(grep "VERSION: " ${IMPALA_VERSION_INFO_FILE} | awk '{print $2}')
|
|
GIT_HASH=$(grep "GIT_HASH: " ${IMPALA_VERSION_INFO_FILE} | awk '{print $2}')
|
|
BUILD_DATE=$(grep "BUILD_TIME: " ${IMPALA_VERSION_INFO_FILE} | cut -f 2- -d ' ')
|
|
cat ${IMPALA_VERSION_INFO_FILE}
|
|
|
|
SHELL_HOME=${IMPALA_HOME}/shell
|
|
BUILD_DIR=${SHELL_HOME}/build
|
|
TARBALL_ROOT=${BUILD_DIR}/impala-shell-${VERSION}
|
|
|
|
IMPALA_THRIFT_PY_VERSION="${IMPALA_THRIFT_VERSION}"
|
|
THRIFT_GEN_PY_DIR="${SHELL_HOME}/gen-py"
|
|
|
|
echo "Deleting all files in ${TARBALL_ROOT}/{gen-py,lib,ext-py}"
|
|
rm -rf ${TARBALL_ROOT}/lib/* 2>&1 > /dev/null
|
|
rm -rf ${TARBALL_ROOT}/gen-py/* 2>&1 > /dev/null
|
|
rm -rf ${TARBALL_ROOT}/ext-py/* 2>&1 > /dev/null
|
|
mkdir -p ${TARBALL_ROOT}/lib
|
|
mkdir -p ${TARBALL_ROOT}/ext-py
|
|
|
|
rm -f ${THRIFT_GEN_PY_DIR}/impala_build_version.py
|
|
cat > ${THRIFT_GEN_PY_DIR}/impala_build_version.py <<EOF
|
|
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
def get_version():
|
|
return "${VERSION}"
|
|
|
|
def get_git_hash():
|
|
return "${GIT_HASH}"
|
|
|
|
def get_build_date():
|
|
return "${BUILD_DATE}"
|
|
EOF
|
|
|
|
# Building all eggs.
|
|
echo "Building all external modules into eggs"
|
|
for MODULE in ${SHELL_HOME}/ext-py/*; do
|
|
# Sometimes there are leftover module directories from version changes. If IMPALA_HOME
|
|
# is a git repository, then we can check if the module directory is tracked by git.
|
|
# If it is not tracked, skip building it. The downside of this check is that when
|
|
# adding a new directory, it won't build until added in git. This check does not apply
|
|
# when IMPALA_HOME is not a git repository (e.g. if building from a release tarball).
|
|
if ${IS_GIT_CHECKOUT} &&
|
|
! git ls-files --error-unmatch ${MODULE} > /dev/null 2>&1 ; then
|
|
echo "WARNING: ${MODULE} is not tracked by the git repository, skipping..."
|
|
continue;
|
|
fi
|
|
pushd ${MODULE} > /dev/null 2>&1
|
|
echo "Cleaning up old build artifacts."
|
|
rm -rf dist 2>&1 > /dev/null
|
|
rm -rf build 2>&1 > /dev/null
|
|
echo "Creating an egg for ${MODULE}"
|
|
if [[ "$MODULE" == *"/bitarray"* ]]; then
|
|
# Need to use setuptools to build egg for bitarray module
|
|
python -c "import setuptools; exec(open('setup.py').read())" -q bdist_egg
|
|
else
|
|
python setup.py -q bdist_egg clean
|
|
fi
|
|
cp dist/*.egg ${TARBALL_ROOT}/ext-py
|
|
popd 2>&1 > /dev/null
|
|
done
|
|
|
|
# Copy all the shell files into the build dir
|
|
# The location of python libs for thrift is different in rhel/centos/sles
|
|
|
|
THRIFT_PY_ROOT="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/thrift-${IMPALA_THRIFT_PY_VERSION}"
|
|
|
|
if [ -d ${THRIFT_PY_ROOT}/python/lib/python*/site-packages/thrift ]; then
|
|
cp -r ${THRIFT_PY_ROOT}/python/lib/python*/site-packages/thrift\
|
|
${TARBALL_ROOT}/lib
|
|
else
|
|
cp -r ${THRIFT_PY_ROOT}/python/lib64/python*/site-packages/thrift\
|
|
${TARBALL_ROOT}/lib
|
|
fi
|
|
|
|
cp -r ${THRIFT_GEN_PY_DIR} ${TARBALL_ROOT}
|
|
cp ${SHELL_HOME}/option_parser.py ${TARBALL_ROOT}/lib
|
|
cp ${SHELL_HOME}/impala_shell_config_defaults.py ${TARBALL_ROOT}/lib
|
|
cp ${SHELL_HOME}/impala_client.py ${TARBALL_ROOT}/lib
|
|
cp ${SHELL_HOME}/TSSLSocketWithWildcardSAN.py ${TARBALL_ROOT}/lib
|
|
cp ${SHELL_HOME}/ImpalaHttpClient.py ${TARBALL_ROOT}/lib
|
|
cp ${SHELL_HOME}/shell_exceptions.py ${TARBALL_ROOT}/lib
|
|
cp ${SHELL_HOME}/shell_output.py ${TARBALL_ROOT}/lib
|
|
cp ${SHELL_HOME}/pkg_resources.py ${TARBALL_ROOT}/lib
|
|
cp ${SHELL_HOME}/cookie_util.py ${TARBALL_ROOT}/lib
|
|
cp ${SHELL_HOME}/impala-shell ${TARBALL_ROOT}
|
|
cp ${SHELL_HOME}/impala_shell.py ${TARBALL_ROOT}
|
|
cp ${SHELL_HOME}/compatibility.py ${TARBALL_ROOT}
|
|
|
|
pushd ${BUILD_DIR} > /dev/null
|
|
echo "Making tarball in ${BUILD_DIR}"
|
|
tar czf ${BUILD_DIR}/impala-shell-${VERSION}.tar.gz ./impala-shell-${VERSION}/\
|
|
--exclude="*.pyc" || popd 2>&1 > /dev/null
|