mirror of
https://github.com/apache/impala.git
synced 2025-12-26 14:02:53 -05:00
This patch improve PlannerTest by printing the path to .test file that is failed. It also skip printing VERBOSE plan if PlannerTestOption.EXTENDED_EXPLAIN is specified, since EXTENDED level already contains sufficient details including tuples, sizes, and cardinality. This patch also change target path to save the updated end-to-end test file if --update_results parameter is set. For example: Before: $EE_TEST_LOGS_DIR/tpcds-decimal_v2-q98.test After: $EE_TEST_LOGS_DIR/impala_updated_results/tpcds/queries/tpcds-decimal_v2-q98.test Also ensure that the updated test file ends with a newline. Testing: - Manualy run modified PlannerTest that will fail and set EXTENDED_EXPLAIN test option. Verified that .test file name is printed and VERBOSE plan is not printed. - Manually run TestTpcdsDecimalV2Query with --update_results parameter and confirm the updated test file path is correct. Change-Id: I5e15af93d9016d78ac0575c433146c8513a11949 Reviewed-on: http://gerrit.cloudera.org:8080/22030 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>