mirror of
https://github.com/apache/impala.git
synced 2026-01-18 15:00:35 -05:00
This patch aligns the sorter's methods closer with the ExecNode methods and moves the possibly-failing parts of Reset() into Open(). Testing: Added WARN_UNUSED_RESULT to all the sorter methods that return Status to prevent similar issues in future. Add a test that sometimes goes down this code path. It was able to cause a crash at least once every 5 executions. Ran an exhaustive build to make sure there were no other regressions. Change-Id: I7d4f9e93a44531901e663b3f1e18edc514363f74 Reviewed-on: http://gerrit.cloudera.org:8080/7134 Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Tested-by: Impala Public Jenkins