mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
c0b3580754
Emits log messages from the OpenTelemetry SDK to the Impalad DEBUG, INFO, WARNING, and ERROR logs. Previously, these SDK log messages were dropped. Modifies the function of the 'otel_debug' startup flag. This flag defaults to 'false' which causes log messages from the SDK to be dropped. When set to 'true', log messages from the OpenTelemetry SDK will be sent to the Impala logging system. The overall glog level is applied to all messages sent from the OpenTelemetry SDK, thus DEBUG SDK logs will not appear in the Impalad logs unless the glog level is greater than or equal to 2. When a trace is successfully sent to the OpenTelemetry collector, zero log lines are generated. When a trace cannot be sent, local testing showed 12 lines with a total size around 3k were written between the impalad.ERROR and impalad.WARNING log files. The request body is not included in these log messages unless the glog level is greater than or equal to 2 thus log message size will not grow or shrink based on the size of the trace(s). This patch also removes the completely useless 'LoggingInstrumentation' class. Previously, the 'otel_debug' flag caused this class to log messages, but those messages provided no insightful information. Generated-by: Github Copilot (Claude Sonnet 3.7) Change-Id: I41aba21f46233e6430eede9606be1e791071717a Reviewed-on: http://gerrit.cloudera.org:8080/23418 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>