mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
c26e3db4bd
Upgrades the impala-shell's bundled version of sqlparse to 0.3.1. There were some API changes in 0.2.0+ that required a re-write of the StripLeadingCommentFilter in impala_shell.py. A slight perf optimization was also added to avoid using the filter altogether if no leading comment is readily discernible. As 0.1.19 was the last version of sqlparse to support python 2.6, this patch also breaks Impala's compatibility with python 2.6. No new tests were added, but all existing tests passed without modification. Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 Reviewed-on: http://gerrit.cloudera.org:8080/15642 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
146 lines
4.2 KiB
Python
146 lines
4.2 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
import subprocess
|
|
import sys
|
|
|
|
import pytest
|
|
|
|
import sqlparse
|
|
|
|
|
|
def test_cli_main_empty():
|
|
with pytest.raises(SystemExit):
|
|
sqlparse.cli.main([])
|
|
|
|
|
|
def test_parser_empty():
|
|
with pytest.raises(SystemExit):
|
|
parser = sqlparse.cli.create_parser()
|
|
parser.parse_args([])
|
|
|
|
|
|
def test_main_help():
|
|
# Call with the --help option as a basic sanity check.
|
|
with pytest.raises(SystemExit) as exinfo:
|
|
sqlparse.cli.main(["--help", ])
|
|
assert exinfo.value.code == 0
|
|
|
|
|
|
def test_valid_args(filepath):
|
|
# test doesn't abort
|
|
path = filepath('function.sql')
|
|
assert sqlparse.cli.main([path, '-r']) is not None
|
|
|
|
|
|
def test_invalid_choice(filepath):
|
|
path = filepath('function.sql')
|
|
with pytest.raises(SystemExit):
|
|
sqlparse.cli.main([path, '-l', 'Spanish'])
|
|
|
|
|
|
def test_invalid_args(filepath, capsys):
|
|
path = filepath('function.sql')
|
|
sqlparse.cli.main([path, '-r', '--indent_width', '0'])
|
|
_, err = capsys.readouterr()
|
|
assert err == ("[ERROR] Invalid options: indent_width requires "
|
|
"a positive integer\n")
|
|
|
|
|
|
def test_invalid_infile(filepath, capsys):
|
|
path = filepath('missing.sql')
|
|
sqlparse.cli.main([path, '-r'])
|
|
_, err = capsys.readouterr()
|
|
assert err[:22] == "[ERROR] Failed to read"
|
|
|
|
|
|
def test_invalid_outfile(filepath, capsys):
|
|
path = filepath('function.sql')
|
|
outpath = filepath('/missing/function.sql')
|
|
sqlparse.cli.main([path, '-r', '-o', outpath])
|
|
_, err = capsys.readouterr()
|
|
assert err[:22] == "[ERROR] Failed to open"
|
|
|
|
|
|
def test_stdout(filepath, load_file, capsys):
|
|
path = filepath('begintag.sql')
|
|
expected = load_file('begintag.sql')
|
|
sqlparse.cli.main([path])
|
|
out, _ = capsys.readouterr()
|
|
assert out == expected
|
|
|
|
|
|
def test_script():
|
|
# Call with the --help option as a basic sanity check.
|
|
cmd = "{0:s} -m sqlparse.cli --help".format(sys.executable)
|
|
assert subprocess.call(cmd.split()) == 0
|
|
|
|
|
|
def test_encoding_utf8_stdout(filepath, load_file, capfd):
|
|
path = filepath('encoding_utf8.sql')
|
|
expected = load_file('encoding_utf8.sql', 'utf-8')
|
|
sys.stdout.encoding = 'utf-8'
|
|
sqlparse.cli.main([path])
|
|
out, _ = capfd.readouterr()
|
|
assert out == expected
|
|
|
|
|
|
def test_encoding_utf8_output_file(filepath, load_file, tmpdir):
|
|
in_path = filepath('encoding_utf8.sql')
|
|
expected = load_file('encoding_utf8.sql', 'utf-8')
|
|
out_path = tmpdir.dirname + '/encoding_utf8.out.sql'
|
|
sqlparse.cli.main([in_path, '-o', out_path])
|
|
out = load_file(out_path, 'utf-8')
|
|
assert out == expected
|
|
|
|
|
|
def test_encoding_gbk_stdout(filepath, load_file, capfd):
|
|
path = filepath('encoding_gbk.sql')
|
|
expected = load_file('encoding_gbk.sql', 'gbk')
|
|
sys.stdout.encoding = 'gbk'
|
|
sqlparse.cli.main([path, '--encoding', 'gbk'])
|
|
out, _ = capfd.readouterr()
|
|
assert out == expected
|
|
|
|
|
|
def test_encoding_gbk_output_file(filepath, load_file, tmpdir):
|
|
in_path = filepath('encoding_gbk.sql')
|
|
expected = load_file('encoding_gbk.sql', 'gbk')
|
|
out_path = tmpdir.dirname + '/encoding_gbk.out.sql'
|
|
sqlparse.cli.main([in_path, '--encoding', 'gbk', '-o', out_path])
|
|
out = load_file(out_path, 'gbk')
|
|
assert out == expected
|
|
|
|
|
|
def test_encoding_stdin_utf8(filepath, load_file, capfd):
|
|
path = filepath('encoding_utf8.sql')
|
|
expected = load_file('encoding_utf8.sql', 'utf-8')
|
|
old_stdin = sys.stdin
|
|
with open(path, 'r') as f:
|
|
sys.stdin = f
|
|
sys.stdout.encoding = 'utf-8'
|
|
sqlparse.cli.main(['-'])
|
|
sys.stdin = old_stdin
|
|
out, _ = capfd.readouterr()
|
|
assert out == expected
|
|
|
|
|
|
def test_encoding_stdin_gbk(filepath, load_file, capfd):
|
|
path = filepath('encoding_gbk.sql')
|
|
expected = load_file('encoding_gbk.sql', 'gbk')
|
|
old_stdin = sys.stdin
|
|
with open(path, 'r') as stream:
|
|
sys.stdin = stream
|
|
sys.stdout.encoding = 'gbk'
|
|
sqlparse.cli.main(['-', '--encoding', 'gbk'])
|
|
sys.stdin = old_stdin
|
|
out, _ = capfd.readouterr()
|
|
assert out == expected
|
|
|
|
|
|
def test_encoding(filepath, capsys):
|
|
path = filepath('test_cp1251.sql')
|
|
expected = u'insert into foo values (1); -- Песня про надежду\n'
|
|
sqlparse.cli.main([path, '--encoding=cp1251'])
|
|
out, _ = capsys.readouterr()
|
|
assert out == expected
|