mirror of
https://github.com/apache/impala.git
synced 2026-01-26 21:02:23 -05:00
bf24a814cc
This adds an IMPALA_HISTFILE environment variable (and --history_file
argument) to the shell which overrides the default location of
~/.impalahistory for the shell history. The shell tests now override
this variable to /dev/null so they don't store history. The tests that
need history use a pytest fixture to use a temporary file for their
history. This allows so that they can run in parallel without stomping
on each other's history.
This also fixes a couple flaky test which were previously missing the
"execute_serially" annotation -- that annotation is no longer needed
after this fix.
A couple of the tests still need to be executed serially because they
look at metrics such as the number of executed or running queries, and
those metrics are unstable if other tests run in parallel.
I tested this by running:
./bin/impala-py.test tests/shell/test_shell_interactive.py \
-m 'not execute_serially' \
-n 80 \
--random
... several times in a row on an 88-core box. Prior to the change,
several would fail each time. Now they pass.
Change-Id: I1da5739276e63a50590dfcb2b050703f8e35fec7
Reviewed-on: http://gerrit.cloudera.org:8080/11045
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Reviewed-by: Todd Lipcon <todd@apache.org>
55 lines
1.9 KiB
Python
55 lines
1.9 KiB
Python
#!/usr/bin/env python
|
|
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
# defaults for OptionParser options stored in dict
|
|
|
|
import getpass
|
|
import os
|
|
import socket
|
|
|
|
_histfile_from_env = os.environ.get(
|
|
'IMPALA_HISTFILE', '~/.impalahistory')
|
|
|
|
impala_shell_defaults = {
|
|
'ca_cert': None,
|
|
'config_file': os.path.expanduser("~/.impalarc"),
|
|
'default_db': None,
|
|
'history_file': _histfile_from_env,
|
|
'history_max': 1000,
|
|
'ignore_query_failure': False,
|
|
'impalad': socket.getfqdn() + ':21000',
|
|
'kerberos_host_fqdn': None,
|
|
'kerberos_service_name': 'impala',
|
|
'output_delimiter': '\\t',
|
|
'output_file': None,
|
|
'print_header': False,
|
|
'print_progress' : False,
|
|
'print_summary' : False,
|
|
'query': None,
|
|
'query_file': None,
|
|
'show_profiles': False,
|
|
'ssl': False,
|
|
'use_kerberos': False,
|
|
'use_ldap': False,
|
|
'user': getpass.getuser(),
|
|
'verbose': True,
|
|
'version': False,
|
|
'write_delimited': False,
|
|
}
|