mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
c78f7a7290
The GetQueryStatus RPC could crash due to a use-after-free error when accessing the reqest. When a query was rejected, the function would call RespondAndReleaseRpc(), which can free the "req" object, and then attempt to access req->query_id() for logging and to delete the entry from the admission_state_map_. This commit fixes the crash by moving the call to RespondAndReleaseRpc() to the end of the function. This change aligns this function with others like AdmissionControlService::ReleaseQuery(), which also deletes from admission_state_map_ before RespondAndReleaseRpc(), it ensures that all logic is completed before the RPC resources are released. Tests: Reproduced the issue by running 100 times TestAdmissionControllerStressWithACService::test_mem_limit, and after the change, it can successfully run 100 times. Passed exhaustive tests. Change-Id: I688954c5c671671cc2dc669ecfdf2405476302d7 Reviewed-on: http://gerrit.cloudera.org:8080/23379 Reviewed-by: Michael Smith <michael.smith@cloudera.com> Tested-by: Michael Smith <michael.smith@cloudera.com>