mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
aefd1b0920
Currently, the shell tarball maintains its own packaging code
and directory layout. This is very complicated and currently has
several Python packages directly checked into our repository.
To simplify it, this changes the shell tarball to be based on
pip installing the pypi package. Specifically, the new directory
structure for an unpack shell tarball is:
impala-shell-4.5.0-SNAPSHOT/
impala-shell
install_py${PYTHON_VERSION}/
install_py${ANOTHER_PYTHON_VERSION}/
For example, install_py2.7 is the Python 2.7 pip install of impala-shell.
install_py3.8 is a Python 3.8 pip install of impala-shell. This means
that the impala-shell script simply picks the install for the
specified version of python and uses that pip install directory.
To make this more consistent across different Linux distributions, this
upgrades pip in the virtualenv to the latest.
With this, ext-py and pkg_resources.py can be removed.
This requires rearranging the shell build code. Specifically, this splits
out the code that generates impala_build_version.py so that it can run
before generating the pypi package. The shell tarball now has a dependency
on the pypi package and must run after it.
This builds on Michael Smith's work from IMPALA-11399.
Testing:
- Ran shell tests locally
- Built on Centos 7, Redhat 8 & 9, Ubuntu 20 & 22, SLES 15
Change-Id: Ifbb66ab2c5bc7180221f98d9bf5e38d62f4ac036
Reviewed-on: http://gerrit.cloudera.org:8080/20171
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
54 lines
2.1 KiB
Bash
Executable File
54 lines
2.1 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
# This script runs the Impala shell. Python is required.
|
|
#
|
|
# This contains installations for different versions of Python in
|
|
# install_py${PYTHON_VERSION} directories (e.g. install_py3.8).
|
|
|
|
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
|
|
SHELL_HOME=${IMPALA_SHELL_HOME:-${SCRIPT_DIR}}
|
|
|
|
# Set the envrionment's locale settings to allow for utf-8 compatibility
|
|
export LC_CTYPE=${LC_CTYPE:-en_US.UTF-8}
|
|
|
|
# Select python version; prefer 2, use 3 if 2's absent. Allow override with envvar
|
|
PYTHON_EXE="${IMPALA_PYTHON_EXECUTABLE:-python}"
|
|
if ! command -v "${PYTHON_EXE}" > /dev/null; then
|
|
PYTHON_EXE=python3
|
|
fi
|
|
|
|
# impala-shell is installed in /install_py${PYTHON_VERSION}
|
|
PYTHON_VERSION=$("${PYTHON_EXE}" -c 'import sys; \
|
|
print("{}.{}".format(sys.version_info.major, sys.version_info.minor))')
|
|
if [ ! -d "${SHELL_HOME}/install_py${PYTHON_VERSION}" ]; then
|
|
# List all install_py* dirs, remove install_py prefix, and join into a comma-separated
|
|
# string.
|
|
dirs=( $(cd ${SHELL_HOME} && echo install_py*) )
|
|
vers="${dirs[@]#install_py}"
|
|
pretty="$(printf "%s, " ${vers[@]})"
|
|
echo "This impala-shell package was not built to support Python ${PYTHON_VERSION}." \
|
|
"Supported Python versions are: ${pretty%, }."
|
|
exit 1
|
|
fi
|
|
|
|
PYTHONIOENCODING='utf-8' PYTHONPATH="${SHELL_HOME}/install_py${PYTHON_VERSION}" \
|
|
exec ${PYTHON_EXE} -m "impala_shell.impala_shell" "$@"
|