mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
82bd087fb1
This takes steps to make Python 2 behave like Python 3 as
a way to flush out issues with running on Python 3. Specifically,
it handles two main differences:
1. Python 3 requires absolute imports within packages. This
can be emulated via "from __future__ import absolute_import"
2. Python 3 changed division to "true" division that doesn't
round to an integer. This can be emulated via
"from __future__ import division"
This changes all Python files to add imports for absolute_import
and division. For completeness, this also includes print_function in the
import.
I scrutinized each old-division location and converted some locations
to use the integer division '//' operator if it needed an integer
result (e.g. for indices, counts of records, etc). Some code was also using
relative imports and needed to be adjusted to handle absolute_import.
This fixes all Pylint warnings about no-absolute-import and old-division,
and these warnings are now banned.
Testing:
- Ran core tests
Change-Id: Idb0fcbd11f3e8791f5951c4944be44fb580e576b
Reviewed-on: http://gerrit.cloudera.org:8080/19588
Reviewed-by: Joe McDonnell <joemcdonnell@cloudera.com>
Tested-by: Joe McDonnell <joemcdonnell@cloudera.com>
48 lines
2.1 KiB
Python
48 lines
2.1 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
import pytest
|
|
|
|
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
|
|
from tests.common.skip import SkipIfBuildType
|
|
|
|
@SkipIfBuildType.not_dev_build
|
|
class TestAllocFail(CustomClusterTestSuite):
|
|
"""Tests for handling malloc() failure for UDF/UDA"""
|
|
|
|
@classmethod
|
|
def get_workload(self):
|
|
return 'functional-query'
|
|
|
|
@pytest.mark.execute_serially
|
|
@CustomClusterTestSuite.with_args("--stress_fn_ctx_alloc=1")
|
|
def test_alloc_fail_init(self, vector):
|
|
self.run_test_case('QueryTest/alloc-fail-init', vector)
|
|
|
|
# TODO: Rewrite or remove the non-deterministic test.
|
|
@pytest.mark.xfail(run=True, reason="IMPALA-2925: the execution is not deterministic "
|
|
"so some tests sometimes don't fail as expected")
|
|
@pytest.mark.execute_serially
|
|
@CustomClusterTestSuite.with_args("--stress_fn_ctx_alloc=3")
|
|
def test_alloc_fail_update(self, vector, unique_database):
|
|
# Note that this test relies on pre-aggregation to exercise the Serialize() path so
|
|
# query option 'num_nodes' must not be 1. CustomClusterTestSuite.add_test_dimensions()
|
|
# already filters out vectors with 'num_nodes' != 0 so just assert it here.
|
|
assert vector.get_value('exec_option')['num_nodes'] == 0
|
|
self.run_test_case('QueryTest/alloc-fail-update', vector, use_db=unique_database)
|