Files
impala/tests/custom_cluster/test_query_event_hooks.py
Riza Suminto 95f353ac4a IMPALA-13507: Allow disabling glog buffering via with_args fixture
We have plenty of custom_cluster tests that assert against content of
Impala daemon log files while the process is still running using
assert_log_contains() and it's wrappers. The method specifically mention
about disabling glog buffering ('-logbuflevel=-1'), but not all
custom_cluster tests do that. This often result in flaky test that hard
to triage and often neglected if it does not frequently run in core
exploration.

This patch adds boolean param 'disable_log_buffering' into
CustomClusterTestSuite.with_args for test to declare intention to
inspect log files in live minicluster. If it is True, start minicluster
with '-logbuflevel=-1' for all daemons. If it is False, log WARNING on
any calls to assert_log_contains().

There are several complex custom_cluster tests that left unchanged and
print out such WARNING logs, such as:
- TestQueryLive
- TestQueryLogTableBeeswax
- TestQueryLogOtherTable
- TestQueryLogTableHS2
- TestQueryLogTableAll
- TestQueryLogTableBufferPool
- TestStatestoreRpcErrors
- TestWorkloadManagementInitWait
- TestWorkloadManagementSQLDetails

This patch also fixed some small flake8 issues on modified tests.

There is a flakiness sign at test_query_live.py where test query is
submitted to coordinator and fail because sys.impala_query_live table
has not exist yet from coordinator's perspective. This patch modify
test_query_live.py to wait for few seconds until sys.impala_query_live
is queryable.

Testing:
- Pass custom_cluster tests in exhaustive exploration.

Change-Id: I56fb1746b8f3cea9f3db3514a86a526dffb44a61
Reviewed-on: http://gerrit.cloudera.org:8080/22015
Reviewed-by: Jason Fehr <jfehr@cloudera.com>
Reviewed-by: Michael Smith <michael.smith@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
2024-11-05 04:49:05 +00:00

119 lines
4.8 KiB
Python

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#
# Client tests for Query Event Hooks
from __future__ import absolute_import, division, print_function
import pytest
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
class TestHooks(CustomClusterTestSuite):
"""
Tests for FE QueryEventHook invocations.
"""
DUMMY_HOOK = "org.apache.impala.testutil.DummyQueryEventHook"
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(
impala_log_dir="{query_event_hooks_log}",
impalad_args=("--query_event_hook_classes={0} -logbuflevel=-1 ".format(DUMMY_HOOK)
+ "--minidump_path={query_event_hooks_minidump}"),
catalogd_args="--minidump_path={query_event_hooks_minidump}",
tmp_dir_placeholders=['query_event_hooks_log', 'query_event_hooks_minidump'],
disable_log_buffering=True)
def test_query_event_hooks_execute(self):
"""
Tests that the post query execution hook actually executes by using a
dummy hook implementation.
"""
# Dummy hook should log something (See org.apache.impala.testutil.DummyQueryEventHook)
self.assert_impalad_log_contains("INFO",
"{0}.onImpalaStartup".format(self.DUMMY_HOOK), expected_count=-1)
# Run a test query that triggers a lineage event.
self.execute_query_expect_success(
self.client, "select count(*) from functional.alltypes")
# onQueryComplete() is invoked by the lineage logger.
self.assert_impalad_log_contains("INFO",
"{0}.onQueryComplete".format(self.DUMMY_HOOK), expected_count=-1)
class TestHooksStartupFail(CustomClusterTestSuite):
"""
Tests for failed startup due to bad QueryEventHook startup or registration
All test cases in this testsuite are expected to fail cluster startup and will
swallow exceptions thrown during setup_method().
"""
@classmethod
def get_workload(cls):
return 'functional-query'
@classmethod
def setup_class(cls):
if cls.exploration_strategy() != 'exhaustive':
pytest.skip('runs only in exhaustive')
super(TestHooksStartupFail, cls).setup_class()
FAILING_HOOK = "org.apache.impala.testutil.AlwaysErrorQueryEventHook"
NONEXIST_HOOK = "captain.hook"
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(
expect_cores=True,
cluster_size=1,
impalad_timeout_s=5,
impala_log_dir="{hook_startup_fail_log}",
impalad_args=("--query_event_hook_classes={0} ".format(FAILING_HOOK)
+ "--minidump_path={hook_startup_fail_minidump}"),
catalogd_args="--minidump_path={hook_startup_fail_minidump}",
tmp_dir_placeholders=['hook_startup_fail_log', 'hook_startup_fail_minidump'],
disable_log_buffering=True)
def test_hook_startup_fail(self):
"""
Tests that exception during QueryEventHook.onImpalaStart will prevent
successful daemon startup.
"""
# Parse log file for expected exception.
self.assert_impalad_log_contains("INFO",
"Exception during onImpalaStartup from "
"QueryEventHook class {0}"
.format(self.FAILING_HOOK), expected_count=-1)
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(
expect_cores=True,
cluster_size=1,
impalad_timeout_s=5,
impala_log_dir="{hook_instantiation_fail_log}",
impalad_args=("--query_event_hook_classes={0} ".format(NONEXIST_HOOK)
+ "--minidump_path={hook_instantiation_fail_minidump}"),
catalogd_args="--minidump_path={hook_instantiation_fail_minidump}",
tmp_dir_placeholders=['hook_instantiation_fail_log',
'hook_instantiation_fail_minidump'],
disable_log_buffering=True)
def test_hook_instantiation_fail(self):
"""
Tests that failure to instantiate a QueryEventHook will prevent
successful daemon startup.
"""
# Parse log file for expected exception.
self.assert_impalad_log_contains("INFO",
"Unable to instantiate query event hook class {0}"
.format(self.NONEXIST_HOOK), expected_count=-1)