mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
95b56d0e2d
This fixes a class of bugs where the planner incorrectly uses the raw string from the parser instead of the unescaped string. This occurs in several places that push predicates down to the storage layer: * Kudu scans * HBase scans * Data source scans There are some more complex issues with escapes and the LIKE predicate that are tracked separately by IMPALA-2422. This also uncovered a different issue with RCFiles that is tracked by IMPALA-7778 and is worked around by the tests added. In order to make bugs like this more obvious in future, I renamed getValue() to getValueWithOriginalEscapes(). Testing: Added regression test that tests handling of backslash escapes on all file formats. I did not add a regression test for the data source bug since it seems to require some major modification of the data source test infrastructure. Change-Id: I53d6e20dd48ab6837ddd325db8a9d49ee04fed28 Reviewed-on: http://gerrit.cloudera.org:8080/11814 Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
67 lines
1.4 KiB
Plaintext
67 lines
1.4 KiB
Plaintext
# This file contains the current output for queries against strings_with_quotes
|
|
# for RCFile. The output is different because of a bug in the RCFile scanner.
|
|
# This file can be removed once IMPALA-7778 is fixed.
|
|
====
|
|
---- QUERY
|
|
# Check that all strings in the table are returned correctly.
|
|
# IMPALA-7778: escapes are ignored so output is incorrect
|
|
select s
|
|
from strings_with_quotes
|
|
---- RESULTS
|
|
'"'
|
|
'""'
|
|
'\\\\"'
|
|
''''''
|
|
''''
|
|
'foo'''
|
|
'''foo'
|
|
'"foo"'
|
|
'"foo'
|
|
'foo"bar'
|
|
'foo\\\\"bar'
|
|
---- TYPES
|
|
STRING
|
|
====
|
|
---- QUERY
|
|
# Regression test for IMPALA-7586: predicate pushed down with incorrect string escaping.
|
|
select s
|
|
from strings_with_quotes
|
|
where s = '"'
|
|
---- RESULTS
|
|
'"'
|
|
---- TYPES
|
|
STRING
|
|
====
|
|
---- QUERY
|
|
# Regression test for IMPALA-7586: predicate pushed down with incorrect string escaping.
|
|
# IMPALA-7778: escapes are ignored so output is incorrect
|
|
select s
|
|
from strings_with_quotes
|
|
where s = '\\"'
|
|
---- RESULTS
|
|
---- TYPES
|
|
STRING
|
|
====
|
|
---- QUERY
|
|
# Regression test for IMPALA-7586: predicate pushed down with incorrect string escaping.
|
|
select s
|
|
from strings_with_quotes
|
|
where s in ('"', 'foo"bar')
|
|
---- RESULTS
|
|
'"'
|
|
'foo"bar'
|
|
---- TYPES
|
|
STRING
|
|
====
|
|
---- QUERY
|
|
# Regression test for IMPALA-7586: predicate pushed down with incorrect string escaping.
|
|
# IMPALA-7778: escapes are ignored so output is incorrect
|
|
select s
|
|
from strings_with_quotes
|
|
where s in ('\\"', 'foo"bar')
|
|
---- RESULTS
|
|
'foo"bar'
|
|
---- TYPES
|
|
STRING
|
|
====
|