mirror of
https://github.com/apache/impala.git
synced 2025-12-25 02:03:09 -05:00
eb8f415f7c
The test was checking the incorrect invariant - the slot mechanism only prevents more than than number of queries running on a backend. More queries can run on a cluster since the query's backends are freed up before the query itself finishes. It was a little tricky picking an appropriate metric since there is no strong consistency between the metrics, e.g. decrementing a metric after a backend finishes may race with admitting the next query. So I simply used the same metric used by the admission controller in making decisions, which should be strongly consistent w.r.t. admission control decissions. Also remove the concurrency limit on the coordinator, which seemed inconsistent with the purpose of the test, because we only want concurrency to be limited by the executors. Testing: Looped the test for a bit. Change-Id: I910028919f248a3bf5de345e9eade9dbc4353ebd Reviewed-on: http://gerrit.cloudera.org:8080/14606 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>