mirror of
https://github.com/apache/impala.git
synced 2026-01-08 21:03:01 -05:00
506a303c6d
Before this patch, when the coordinator returned the last row, it waited for backends to finish of their own accord, which could happen indirectly as exchanges got closed. The idea of this change is to send out cancellation RPCs to expedite cancellation, then wait for the final exec status reports to come in. Those reports will be included in the final profile because the backend is *not* marked as done when sending out the cancellation RPCs. The bulk of this change is modifying the cancellation code path to allow sending the cancel RPCs but *not* consider the backend done until it gets back the final status report. The old "fire and forget" mode of cancellation is still used for explicit cancellation and errors. Testing: Ran exhaustive tests. Ran cancellation tests under TSAN, checked for errors. Manually inspected logs of some queries with limit, saw that it sent cancellation then waited for backends as expected. Added a functional perf test that goes from ~5s down to < ~1s on my system. Change-Id: I966eceaafdc18a019708b780aee4ee9d70fd3a47 Reviewed-on: http://gerrit.cloudera.org:8080/15840 Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
The tests/experiments directory should be used to put test files that are not meant to be run on a regular basis as part of buildall.sh or run-tests.py.