mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
f98b697c7b
This change adds get_workload() to ImpalaTestSuite and removes it from all test suites that already returned 'functional-query'. get_workload() is also removed from CustomClusterTestSuite which used to return 'tpch'. All other changes besides impala_test_suite.py and custom_cluster_test_suite.py are just mass removals of get_workload() functions. The behavior is only changed in custom cluster tests that didn't override get_workload(). By returning 'functional-query' instead of 'tpch', exploration_strategy() will no longer return 'core' in 'exhaustive' test runs. See IMPALA-3947 on why workload affected exploration_strategy. An example for affected test is TestCatalogHMSFailures which was skipped both in core and exhaustive runs before this change. get_workload() functions that return a different workload than 'functional-query' are not changed - it is possible that some of these also don't handle exploration_strategy() as expected, but individually checking these tests is out of scope in this patch. Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115 Reviewed-on: http://gerrit.cloudera.org:8080/22726 Reviewed-by: Riza Suminto <riza.suminto@cloudera.com> Reviewed-by: Daniel Becker <daniel.becker@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
115 lines
4.8 KiB
Python
115 lines
4.8 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
# Client tests for Query Event Hooks
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
import pytest
|
|
|
|
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
|
|
|
|
|
|
class TestHooks(CustomClusterTestSuite):
|
|
"""
|
|
Tests for FE QueryEventHook invocations.
|
|
"""
|
|
DUMMY_HOOK = "org.apache.impala.testutil.DummyQueryEventHook"
|
|
|
|
@pytest.mark.execute_serially
|
|
@CustomClusterTestSuite.with_args(
|
|
impala_log_dir="{query_event_hooks_log}",
|
|
impalad_args=("--query_event_hook_classes={0} -logbuflevel=-1 ".format(DUMMY_HOOK)
|
|
+ "--minidump_path={query_event_hooks_minidump}"),
|
|
catalogd_args="--minidump_path={query_event_hooks_minidump}",
|
|
tmp_dir_placeholders=['query_event_hooks_log', 'query_event_hooks_minidump'],
|
|
disable_log_buffering=True)
|
|
def test_query_event_hooks_execute(self):
|
|
"""
|
|
Tests that the post query execution hook actually executes by using a
|
|
dummy hook implementation.
|
|
"""
|
|
# Dummy hook should log something (See org.apache.impala.testutil.DummyQueryEventHook)
|
|
self.assert_impalad_log_contains("INFO",
|
|
"{0}.onImpalaStartup".format(self.DUMMY_HOOK), expected_count=-1)
|
|
# Run a test query that triggers a lineage event.
|
|
self.execute_query_expect_success(
|
|
self.client, "select count(*) from functional.alltypes")
|
|
# onQueryComplete() is invoked by the lineage logger.
|
|
self.assert_impalad_log_contains("INFO",
|
|
"{0}.onQueryComplete".format(self.DUMMY_HOOK), expected_count=-1)
|
|
|
|
|
|
class TestHooksStartupFail(CustomClusterTestSuite):
|
|
"""
|
|
Tests for failed startup due to bad QueryEventHook startup or registration
|
|
|
|
All test cases in this testsuite are expected to fail cluster startup and will
|
|
swallow exceptions thrown during setup_method().
|
|
"""
|
|
@classmethod
|
|
def setup_class(cls):
|
|
if cls.exploration_strategy() != 'exhaustive':
|
|
pytest.skip('runs only in exhaustive')
|
|
super(TestHooksStartupFail, cls).setup_class()
|
|
|
|
FAILING_HOOK = "org.apache.impala.testutil.AlwaysErrorQueryEventHook"
|
|
NONEXIST_HOOK = "captain.hook"
|
|
|
|
@pytest.mark.execute_serially
|
|
@CustomClusterTestSuite.with_args(
|
|
expect_cores=True,
|
|
cluster_size=1,
|
|
impalad_timeout_s=5,
|
|
impala_log_dir="{hook_startup_fail_log}",
|
|
impalad_args=("--query_event_hook_classes={0} ".format(FAILING_HOOK)
|
|
+ "--minidump_path={hook_startup_fail_minidump}"),
|
|
catalogd_args="--minidump_path={hook_startup_fail_minidump}",
|
|
tmp_dir_placeholders=['hook_startup_fail_log', 'hook_startup_fail_minidump'],
|
|
disable_log_buffering=True)
|
|
def test_hook_startup_fail(self):
|
|
"""
|
|
Tests that exception during QueryEventHook.onImpalaStart will prevent
|
|
successful daemon startup.
|
|
"""
|
|
# Parse log file for expected exception.
|
|
self.assert_impalad_log_contains("INFO",
|
|
"Exception during onImpalaStartup from "
|
|
"QueryEventHook class {0}"
|
|
.format(self.FAILING_HOOK), expected_count=-1)
|
|
|
|
@pytest.mark.execute_serially
|
|
@CustomClusterTestSuite.with_args(
|
|
expect_cores=True,
|
|
cluster_size=1,
|
|
impalad_timeout_s=5,
|
|
impala_log_dir="{hook_instantiation_fail_log}",
|
|
impalad_args=("--query_event_hook_classes={0} ".format(NONEXIST_HOOK)
|
|
+ "--minidump_path={hook_instantiation_fail_minidump}"),
|
|
catalogd_args="--minidump_path={hook_instantiation_fail_minidump}",
|
|
tmp_dir_placeholders=['hook_instantiation_fail_log',
|
|
'hook_instantiation_fail_minidump'],
|
|
disable_log_buffering=True)
|
|
def test_hook_instantiation_fail(self):
|
|
"""
|
|
Tests that failure to instantiate a QueryEventHook will prevent
|
|
successful daemon startup.
|
|
"""
|
|
# Parse log file for expected exception.
|
|
self.assert_impalad_log_contains("INFO",
|
|
"Unable to instantiate query event hook class {0}"
|
|
.format(self.NONEXIST_HOOK), expected_count=-1)
|