mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
f98b697c7b
This change adds get_workload() to ImpalaTestSuite and removes it from all test suites that already returned 'functional-query'. get_workload() is also removed from CustomClusterTestSuite which used to return 'tpch'. All other changes besides impala_test_suite.py and custom_cluster_test_suite.py are just mass removals of get_workload() functions. The behavior is only changed in custom cluster tests that didn't override get_workload(). By returning 'functional-query' instead of 'tpch', exploration_strategy() will no longer return 'core' in 'exhaustive' test runs. See IMPALA-3947 on why workload affected exploration_strategy. An example for affected test is TestCatalogHMSFailures which was skipped both in core and exhaustive runs before this change. get_workload() functions that return a different workload than 'functional-query' are not changed - it is possible that some of these also don't handle exploration_strategy() as expected, but individually checking these tests is out of scope in this patch. Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115 Reviewed-on: http://gerrit.cloudera.org:8080/22726 Reviewed-by: Riza Suminto <riza.suminto@cloudera.com> Reviewed-by: Daniel Becker <daniel.becker@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
53 lines
2.3 KiB
Python
53 lines
2.3 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
# Tests for local and remote disk scheduling.
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
|
|
from tests.common.network import get_external_ip
|
|
from tests.common.skip import SkipIfNotHdfsMinicluster
|
|
|
|
|
|
LOCAL_ASSIGNMENTS_METRIC = "simple-scheduler.local-assignments.total"
|
|
TOTAL_ASSIGNMENTS_METRIC = "simple-scheduler.assignments.total"
|
|
|
|
|
|
@SkipIfNotHdfsMinicluster.tuned_for_minicluster
|
|
class TestSchedulerLocality(CustomClusterTestSuite):
|
|
"""Tests for local and remote disk scheduling."""
|
|
|
|
@CustomClusterTestSuite.with_args(
|
|
impalad_args='--hostname=localhost', cluster_size=1)
|
|
def test_local_assignment(self, vector):
|
|
self.client.execute('select count(1) from functional.alltypes')
|
|
for impalad in self.cluster.impalads:
|
|
impalad.service.wait_for_metric_value(LOCAL_ASSIGNMENTS_METRIC, 1,
|
|
allow_greater=True)
|
|
assignments, local_assignments = impalad.service.get_metric_values([
|
|
TOTAL_ASSIGNMENTS_METRIC, LOCAL_ASSIGNMENTS_METRIC])
|
|
assert assignments == local_assignments
|
|
|
|
@CustomClusterTestSuite.with_args(
|
|
impalad_args='--hostname=' + get_external_ip(), cluster_size=1)
|
|
def test_remote_assignment(self, vector):
|
|
self.client.execute('select count(1) from functional.alltypes')
|
|
for impalad in self.cluster.impalads:
|
|
impalad.service.wait_for_metric_value(TOTAL_ASSIGNMENTS_METRIC, 1,
|
|
allow_greater=True)
|
|
assert impalad.service.get_metric_value(LOCAL_ASSIGNMENTS_METRIC) == 0
|