jprdonnelly/kestra
1
0
Fork 0
mirror of https://github.com/kestra-io/kestra.git synced 2025-12-19 18:05:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): render delete property at the beginning in Docker task runner

Browse Source
This commit is contained in:
brian.mulier
2025-02-14 13:53:20 +01:00
committed by brian-mulier-p
parent 15b85ac952
commit 16e3830c9c
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
script/src/main/java/io/kestra/plugin/scripts/runner/docker/Docker.java
View File

@@ -337,6 +337,8 @@ public class Docker extends TaskRunner<Docker.DockerTaskRunnerDetailResult> {
@Override
public TaskRunnerResult<DockerTaskRunnerDetailResult> run(RunContext runContext, TaskCommands taskCommands, List<String> filesToDownload) throws Exception {
Boolean renderedDelete = runContext.render(delete).as(Boolean.class).orElseThrow();
if (taskCommands.getContainerImage() == null && this.image == null) {
throw new IllegalArgumentException("This task runner needs the `containerImage` property to be set");
}
@@ -538,7 +540,7 @@ public class Docker extends TaskRunner<Docker.DockerTaskRunnerDetailResult> {
// come to a normal end.
kill();
if (Boolean.TRUE.equals(runContext.render(delete).as(Boolean.class).orElseThrow())) {
if (Boolean.TRUE.equals(renderedDelete)) {
dockerClient.removeContainerCmd(exec.getId()).exec();
if (logger.isTraceEnabled()) {
logger.trace("Container deleted: {}", exec.getId());