refactor(core): simplify changes by using variable

This commit is contained in:
mustafatarek
2025-12-08 15:44:09 +02:00
committed by Loïc Mathieu
parent 2951f4b4bc
commit c6cf0147a4

View File

@@ -56,6 +56,20 @@ public class InputsTest {
@Inject @Inject
private NamespaceFactory namespaceFactory; private NamespaceFactory namespaceFactory;
private static final Map<String , Object> yamlAndJsonObject = Map.of(
"people",
Map.of(
"name1", List.of(
Map.of("first1", "Mustafa"),
Map.of( "last1", "Tarek")
)
,
"name2", List.of(
Map.of("first2", "Ahmed"),
Map.of("last2", "Tarek")
)
)
);
public static Map<String, Object> inputs = ImmutableMap.<String, Object>builder() public static Map<String, Object> inputs = ImmutableMap.<String, Object>builder()
.put("string", "myString") .put("string", "myString")
.put("enum", "ENUM_VALUE") .put("enum", "ENUM_VALUE")
@@ -83,20 +97,7 @@ public class InputsTest {
.put("json1", "{\"a\": \"b\"}") .put("json1", "{\"a\": \"b\"}")
.put( .put(
"json2", "json2",
Map.of( yamlAndJsonObject
"people",
Map.of(
"name1", List.of(
Map.of("first1", "Mustafa"),
Map.of( "last1", "Tarek")
)
,
"name2", List.of(
Map.of("first2", "Ahmed"),
Map.of("last2", "Tarek")
)
)
)
) )
.put("yaml1", """ .put("yaml1", """
some: property some: property
@@ -105,20 +106,7 @@ public class InputsTest {
- values""") - values""")
.put( .put(
"yaml2", "yaml2",
Map.of( yamlAndJsonObject
"people",
Map.of(
"name1", List.of(
Map.of("first1", "Mustafa"),
Map.of( "last1", "Tarek")
)
,
"name2", List.of(
Map.of("first2", "Ahmed"),
Map.of("last2", "Tarek")
)
)
)
) )
.build(); .build();
@@ -204,45 +192,11 @@ public class InputsTest {
assertThat((List<Integer>) typeds.get("array")).hasSize(3); assertThat((List<Integer>) typeds.get("array")).hasSize(3);
assertThat((List<Integer>) typeds.get("array")).isEqualTo(List.of(1, 2, 3)); assertThat((List<Integer>) typeds.get("array")).isEqualTo(List.of(1, 2, 3));
assertThat(typeds.get("json1")).isEqualTo(Map.of("a", "b")); assertThat(typeds.get("json1")).isEqualTo(Map.of("a", "b"));
assertThat(typeds.get("json2")) assertThat(typeds.get("json2")).isEqualTo(yamlAndJsonObject);
.isEqualTo(
Map.of(
"people",
Map.of(
"name1", List.of(
Map.of("first1", "Mustafa"),
Map.of( "last1", "Tarek")
)
,
"name2", List.of(
Map.of("first2", "Ahmed"),
Map.of("last2", "Tarek")
)
)
)
);
assertThat(typeds.get("yaml1")).isEqualTo(Map.of( assertThat(typeds.get("yaml1")).isEqualTo(Map.of(
"some", "property", "some", "property",
"alist", List.of("of", "values"))); "alist", List.of("of", "values")));
assertThat(typeds.get("yaml2")) assertThat(typeds.get("yaml2")).isEqualTo(yamlAndJsonObject);
.isEqualTo(
Map.of(
"people",
Map.of(
"name1", List.of(
Map.of("first1", "Mustafa"),
Map.of( "last1", "Tarek")
)
,
"name2", List.of(
Map.of("first2", "Ahmed"),
Map.of("last2", "Tarek")
)
)
)
);
} }
@Test @Test