mirror of
https://github.com/qlik-oss/nebula.js.git
synced 2026-05-24 16:00:16 -04:00
fix: do not crash on unknown chart + footer (#1268)
* fix: do not krash on unknown chart + footer * chore: use undefined instead
This commit is contained in:
@@ -569,7 +569,7 @@ const Cell = forwardRef(
|
||||
>
|
||||
{Content}
|
||||
</Grid>
|
||||
<Footer layout={layout} titleStyles={titleStyles} />
|
||||
{cellNode && layout && state.sn && <Footer layout={layout} titleStyles={titleStyles} />}
|
||||
</Grid>
|
||||
{state.longRunningQuery && <LongRunningQuery canCancel={canCancel} canRetry={canRetry} api={longrunning} />}
|
||||
</Paper>
|
||||
|
||||
@@ -101,9 +101,9 @@ describe('types', () => {
|
||||
expect(v).toEqual('1.5.1');
|
||||
});
|
||||
|
||||
test('should return null when no fit is found', () => {
|
||||
test('should return undefined when no fit is found', () => {
|
||||
const v = c.getSupportedVersion('pie', '1.2.0');
|
||||
expect(v).toBe(null);
|
||||
expect(v).toBe(undefined);
|
||||
});
|
||||
|
||||
test('should return the requested type and version', () => {
|
||||
|
||||
@@ -66,7 +66,7 @@ export function create({ halo, parent }) {
|
||||
},
|
||||
getSupportedVersion: (name, propertyVersion) => {
|
||||
if (!tc[name]) {
|
||||
return null;
|
||||
return undefined;
|
||||
}
|
||||
return tc[name].getMatchingVersionFromProperties(propertyVersion);
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user