From 20c4a99fa0107f12b359af9e3c67d015ab3d121f Mon Sep 17 00:00:00 2001 From: Tobias Linsefors Date: Mon, 1 Dec 2025 09:19:41 +0100 Subject: [PATCH] fix: always padd title - to match change in sense-client --- .../src/utils/__tests__/cell-padding.test.js | 4 ++-- apis/nucleus/src/utils/cell-padding.js | 24 +++++-------------- 2 files changed, 8 insertions(+), 20 deletions(-) diff --git a/apis/nucleus/src/utils/__tests__/cell-padding.test.js b/apis/nucleus/src/utils/__tests__/cell-padding.test.js index 03d9a15b8..9e98019f2 100644 --- a/apis/nucleus/src/utils/__tests__/cell-padding.test.js +++ b/apis/nucleus/src/utils/__tests__/cell-padding.test.js @@ -172,7 +172,7 @@ describe('cell padding', () => { subtitle: 'X', }); expect(bodyPadding).toBeUndefined(); - expect(titleStyles.main.padding).toBe('10px 0 0'); - expect(titleStyles.subTitle.padding).toBe('0'); + expect(titleStyles.main.padding).toBe('10px 10px 0'); + expect(titleStyles.subTitle.padding).toBe('0 10px'); }); }); diff --git a/apis/nucleus/src/utils/cell-padding.js b/apis/nucleus/src/utils/cell-padding.js index 769402ef1..cd68134cf 100644 --- a/apis/nucleus/src/utils/cell-padding.js +++ b/apis/nucleus/src/utils/cell-padding.js @@ -14,24 +14,12 @@ const NO_PADDING_IN_CARDS = [ 'sn-tabbed-container', ]; -const getPaddTitle = (visualization) => NO_BORDER_IN_CARDS.indexOf(visualization) === -1; - -const getTitlePadding = (visualization) => { - const paddTitle = getPaddTitle(visualization); - if (paddTitle) { - return '10px 10px 0'; - } - return '10px 0 0'; -}; -const getSubtitlePadding = (visualization, showTitle) => { - const paddTitle = getPaddTitle(visualization); +const getTitlePadding = () => '10px 10px 0'; +const getSubtitlePadding = (showTitle) => { if (showTitle) { - if (paddTitle) { - return '0 10px'; - } - return '0'; + return '0 10px'; } - return getTitlePadding(visualization); + return getTitlePadding(); }; const getPadding = ({ layout, isError, isCardTheme, titleStyles, translator }) => { @@ -46,11 +34,11 @@ const getPadding = ({ layout, isError, isCardTheme, titleStyles, translator }) = if (showTitle) { // eslint-disable-next-line no-param-reassign - titleStyles.main.padding = getTitlePadding(visualization); + titleStyles.main.padding = getTitlePadding(); } if (showSubtitle) { // eslint-disable-next-line no-param-reassign - titleStyles.subTitle.padding = getSubtitlePadding(visualization, showTitle); + titleStyles.subTitle.padding = getSubtitlePadding(showTitle); } if (showFootnote) { if (NO_BORDER_IN_CARDS.indexOf(visualization) === -1) {