fix: pick up and apply font-size in dense listboxes (#1709)

This commit is contained in:
Christian Veinfors
2025-04-01 09:32:36 +02:00
committed by GitHub
parent 45758938b4
commit 56214c5b54
6 changed files with 23 additions and 2 deletions

View File

@@ -145,7 +145,7 @@ const RowColRoot = styled('div', {
// The leaf node, containing the label text. // The leaf node, containing the label text.
[`& .${classes.labelText}`]: { [`& .${classes.labelText}`]: {
lineHeight: '16px', lineHeight: '24px',
userSelect: 'none', userSelect: 'none',
paddingRight: '1px', paddingRight: '1px',
...ellipsis, ...ellipsis,
@@ -153,7 +153,7 @@ const RowColRoot = styled('div', {
}, },
[`& .${classes.labelDense}`]: { [`& .${classes.labelDense}`]: {
fontSize: 12, lineHeight: '18px',
}, },
// Highlight is added to labelText spans, which are created as children to original labelText, // Highlight is added to labelText spans, which are created as children to original labelText,

View File

@@ -275,6 +275,7 @@ window.getFuncs = function getFuncs() {
}, },
layoutOptions: { layoutOptions: {
layoutOrder: 'row', layoutOrder: 'row',
dense: options?.dense ?? false,
}, },
}), }),
}; };

View File

@@ -66,6 +66,9 @@
case 'standard': case 'standard':
sc = {}; sc = {};
break; break;
case 'dense':
sc = { dense: true };
break;
case 'autoConfirm': case 'autoConfirm':
sc = { autoConfirm: true }; sc = { autoConfirm: true };
break; break;

View File

@@ -63,6 +63,23 @@ test.describe('listbox mashup rendering test', () => {
return expect(image).toMatchSnapshot(FILE_NAME); return expect(image).toMatchSnapshot(FILE_NAME);
}); });
test('selecting two values in dense listbox should result in two green rows', async () => {
const FILE_NAME = 'listbox_dense_select.png';
await page.goto(`${url}/listbox/listbox.html?scenario=dense`, { waitUntil: 'networkidle' });
const selector = await page.waitForSelector(listboxSelector, { visible: true });
const selectNumbers = [4, 7];
const action = async (nbr) => {
const rowSelector = `${listboxSelector} [data-n="${nbr}"]`;
await page.click(rowSelector);
};
await execSequence(selectNumbers, action);
const image = await selector.screenshot({ caret: 'hide' });
return expect(image).toMatchSnapshot(FILE_NAME);
});
test('selecting values should not show the selections toolbar when autoConfirm is true', async () => { test('selecting values should not show the selections toolbar when autoConfirm is true', async () => {
const FILE_NAME = 'listbox_select_EH_auto_confirm.png'; const FILE_NAME = 'listbox_select_EH_auto_confirm.png';

Binary file not shown.

After

Width:  |  Height:  |  Size: 7.7 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 68 KiB

After

Width:  |  Height:  |  Size: 67 KiB