jprdonnelly/nebula.js
1
0
Fork 0
mirror of https://github.com/qlik-oss/nebula.js.git synced 2025-12-20 02:08:58 -05:00
Code Issues Projects Releases Wiki Activity

feat(cli-serve): improve remote configs (#245)

Browse Source
This commit is contained in:
Miralem Drek
2019-12-18 19:03:45 +01:00
committed by GitHub
parent 5b4ea46725
commit a08cf8ccd8
15 changed files with 358 additions and 186 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
commands/serve/lib/serve.js
View File

@@ -90,7 +90,11 @@ module.exports = async argv => {
let snPath;
let snName;
let watcher;
if (serveConfig.entry) {
let snUrl;
if (/^https?/.test(serveConfig.entry)) {
snName = 'remote';
snUrl = serveConfig.entry;
} else if (serveConfig.entry) {
snPath = path.resolve(context, serveConfig.entry);
const parsed = path.parse(snPath);
snName = parsed.name;
@@ -111,7 +115,7 @@ module.exports = async argv => {
}
}
const ww = await initiateWatch({ snPath, snName: serveConfig.type || snName, host });
const ww = snUrl ? null : await initiateWatch({ snPath, snName: serveConfig.type || snName, host });
const server = await webpackServe({
host,
@@ -119,7 +123,7 @@ module.exports = async argv => {
enigmaConfig,
webIntegrationId: serveConfig.webIntegrationId,
snName: serveConfig.type || snName,
snPath,
snUrl,
dev: process.env.MONO === 'true',
open: serveConfig.open !== false,
entryWatcher: ww,