jprdonnelly/nebula.js
1
0
Fork 0
mirror of https://github.com/qlik-oss/nebula.js.git synced 2025-12-19 17:58:43 -05:00
Code Issues Projects Releases Wiki Activity

fix: check for no prefix and update help text (#1731)

Browse Source
This commit is contained in:
Tobias Åström
2025-05-05 11:01:53 +02:00
committed by GitHub
parent a7617b5417
commit f65c678c80
4 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
commands/serve/web/components/Hub/SelectEngine/ConnectionGuid.jsx
View File

@@ -71,6 +71,14 @@ const ConnectionGuid = ({ showGuid }) => (
<code>{window.location.host}</code> needs to be whitelisted in QMC in your Qlik Sense on Windows deployment. In <code>{window.location.host}</code> needs to be whitelisted in QMC in your Qlik Sense on Windows deployment. In
addition, you need to enable <i>Has secure attribute</i> and set <i>SameSite attribute</i> to <i>None</i>. addition, you need to enable <i>Has secure attribute</i> and set <i>SameSite attribute</i> to <i>None</i>.
<br /> <br />
Also some &quot;Additional reponse headers&quot; needs to align with the whitelisted domain:
<ul>
<li>
Access-Control-Allow-Origin: <code>{window.location.host}</code>
</li>
<li>Access-Control-Allow-Credentials: true</li>
<li>Access-Control-Expose-Headers: qlik-csrf-token</li>
</ul>
Make sure you are logged in to Qlik Sense in another browser tab. Make sure you are logged in to Qlik Sense in another browser tab.
</Typography> </Typography>
<Typography variant="subtitle1" gutterBottom> <Typography variant="subtitle1" gutterBottom>

4
commands/serve/web/connect.js
View File

@@ -168,7 +168,9 @@ const connect = async () => {
}; };
} }
const csrfToken = await getCsrfToken(`https://${enigmaInfo.host}/${enigmaInfo.prefix}`); const csrfToken = await getCsrfToken(
`https://${enigmaInfo.host}${enigmaInfo.prefix ? `/${enigmaInfo.prefix}` : ''}`
);
const url = SenseUtilities.buildUrl({ const url = SenseUtilities.buildUrl({
secure: false, secure: false,
...enigmaInfo, ...enigmaInfo,

4
commands/serve/web/hooks/useOpenApp.js
View File

@@ -30,7 +30,9 @@ export const useOpenApp = ({ info }) => {
const { webSocketUrl } = await (await fetch(`/auth/getSocketUrl/${info?.enigma.appId}`)).json(); const { webSocketUrl } = await (await fetch(`/auth/getSocketUrl/${info?.enigma.appId}`)).json();
url = webSocketUrl; url = webSocketUrl;
} else { } else {
const csrfToken = await getCsrfToken(`https://${enigmaInfo.host}/${enigmaInfo.prefix}`); const csrfToken = await getCsrfToken(
`https://${enigmaInfo.host}${enigmaInfo.prefix ? `/${enigmaInfo.prefix}` : ''}`
);
url = SenseUtilities.buildUrl({ ...enigmaInfo, ...{ urlParams: { 'qlik-csrf-token': csrfToken } } }); url = SenseUtilities.buildUrl({ ...enigmaInfo, ...{ urlParams: { 'qlik-csrf-token': csrfToken } } });
} }

6
commands/serve/web/utils/getCsrfToken.js
View File

@@ -1,7 +1,11 @@
export default async function getCsrfToken(host) { export default async function getCsrfToken(host) {
try { try {
const res = await fetch(`${host}/qps/csrftoken`, { credentials: 'include' }); const res = await fetch(`${host}/qps/csrftoken`, { credentials: 'include' });
return res.headers.get('QLIK-CSRF-TOKEN'); const token = res.headers.get('QLIK-CSRF-TOKEN');
if (token) {
return token;
}
return '';
} catch (err) { } catch (err) {
console.log('Failed to fetch csrf-token', err); console.log('Failed to fetch csrf-token', err);
} }