jprdonnelly/opentf
1
0
Fork 0
mirror of https://github.com/opentffoundation/opentf.git synced 2025-12-25 01:00:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Use the hashicorp/go-version for handling pre-release version constraints during module installation. Adds more tests.

Browse Source 
Signed-off-by: AYM1607 <u.g.a.mariano@gmail.com>
This commit is contained in:
AYM1607
2024-11-01 00:31:25 +00:00
committed by Martin Atkins
parent 6a5c1a2f42
commit 08ad2f5983
11 changed files with 126 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
internal/initwd/module_install_test.go
View File

@@ -244,27 +244,48 @@ func TestModuleInstaller_Prerelease(t *testing.T) {
name string
modulePath string
expectedVersion string
shouldError bool
}{
{
name: "exact match",
modulePath: "testdata/prerelease-version-constraint-match",
modulePath: "testdata/prerelease-constraint-match",
expectedVersion: "v0.0.3-alpha.1",
},
{
name: "exact match v prefix",
modulePath: "testdata/prerelease-version-constraint-match-prefix",
modulePath: "testdata/prerelease-constraint-v-match",
expectedVersion: "v0.0.3-alpha.1",
},
{
name: "exact match eq selector",
modulePath: "testdata/prerelease-constraint-eq-match",
expectedVersion: "v0.0.3-alpha.1",
},
{
name: "exact match v prefix eq selector",
modulePath: "testdata/prerelease-version-constraint-match-prefix-eq",
modulePath: "testdata/prerelease-constraint-v-eq-match",
expectedVersion: "v0.0.3-alpha.1",
},
{
name: "partial match",
modulePath: "testdata/prerelease-version-constraint",
modulePath: "testdata/prerelease-constraint",
expectedVersion: "v0.0.2",
},
{
name: "partial match v prefix",
modulePath: "testdata/prerelease-constraint-v",
expectedVersion: "v0.0.2",
},
{
name: "err",
modulePath: "testdata/prerelease-constraint-err",
shouldError: true,
},
{
name: "err v prefix",
modulePath: "testdata/prerelease-constraint-v-err",
shouldError: true,
},
}
for _, tc := range testCases {
@@ -282,6 +303,13 @@ func TestModuleInstaller_Prerelease(t *testing.T) {
inst := NewModuleInstaller(modulesDir, loader, registry.NewClient(nil, nil))
cfg, diags := inst.InstallModules(context.Background(), ".", "tests", false, false, hooks, configs.RootModuleCallForTesting())
if tc.shouldError {
if !diags.HasErrors() {
t.Fatalf("an error was expected, but none was found")
}
return
}
if diags.HasErrors() {
t.Fatalf("found unexpected errors: %s", diags.Err())
}
@@ -289,6 +317,7 @@ func TestModuleInstaller_Prerelease(t *testing.T) {
if !cfg.Children["acctest"].Version.Equal(version.Must(version.NewVersion(tc.expectedVersion))) {
t.Fatalf("expected version %s but found version %s", tc.expectedVersion, cfg.Version.String())
}
})
}
}