jprdonnelly/opentf
1
0
Fork 0
mirror of https://github.com/opentffoundation/opentf.git synced 2025-12-25 01:00:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Moves validation to PrepareConfig

Browse Source
This commit is contained in:
Graham Davison
2022-10-25 14:23:22 -07:00
parent b5de540643
commit 381006742b
2 changed files with 109 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
internal/backend/remote-state/s3/backend_test.go
View File

@@ -318,38 +318,6 @@ func TestBackendConfig_AssumeRole(t *testing.T) {
}
}
func TestBackendConfig_invalidSSECustomerKeyLength(t *testing.T) {
cfg := populateSchema(t, New().ConfigSchema(), hcl2shim.HCL2ValueFromConfigValue(map[string]interface{}{
"region": "us-west-1",
"bucket": "tf-test",
"encrypt": true,
"key": "state",
"dynamodb_table": "dynamoTable",
"sse_customer_key": "key",
}))
_, diags := New().PrepareConfig(cfg)
if !diags.HasErrors() {
t.Fatal("expected error for invalid sse_customer_key length")
}
}
func TestBackendConfig_invalidSSECustomerKeyEncoding(t *testing.T) {
cfg := populateSchema(t, New().ConfigSchema(), hcl2shim.HCL2ValueFromConfigValue(map[string]interface{}{
"region": "us-west-1",
"bucket": "tf-test",
"encrypt": true,
"key": "state",
"dynamodb_table": "dynamoTable",
"sse_customer_key": "====CT70aTYB2JGff7AjQtwbiLkwH4npICay1PWtmdka",
}))
_, diags := New().PrepareConfig(cfg)
if !diags.HasErrors() {
t.Fatal("expected error for failing to decode sse_customer_key")
}
}
func TestBackendConfig_PrepareConfigValidation(t *testing.T) {
cases := map[string]struct {
config cty.Value
@@ -393,7 +361,7 @@ func TestBackendConfig_PrepareConfigValidation(t *testing.T) {
"key": cty.StringVal("/leading-slash"),
"region": cty.StringVal("us-west-2"),
}),
expectedErr: `key must not start with '/'`,
expectedErr: `key must not start or end with '/'`,
},
"key with trailing slash": {
config: cty.ObjectVal(map[string]cty.Value{
@@ -401,7 +369,7 @@ func TestBackendConfig_PrepareConfigValidation(t *testing.T) {
"key": cty.StringVal("trailing-slash/"),
"region": cty.StringVal("us-west-2"),
}),
expectedErr: `key must not end with '/'`,
expectedErr: `key must not start or end with '/'`,
},
"null region": {
config: cty.ObjectVal(map[string]cty.Value{
@@ -437,6 +405,24 @@ func TestBackendConfig_PrepareConfigValidation(t *testing.T) {
}),
expectedErr: `workspace_key_prefix must not start or end with '/'`,
},
"sse_customer_key invalid length": {
config: cty.ObjectVal(map[string]cty.Value{
"bucket": cty.StringVal("test"),
"key": cty.StringVal("test"),
"region": cty.StringVal("us-west-2"),
"sse_customer_key": cty.StringVal("key"),
}),
expectedErr: `sse_customer_key must be 44 characters in length`,
},
"sse_customer_key invalid encoding": {
config: cty.ObjectVal(map[string]cty.Value{
"bucket": cty.StringVal("test"),
"key": cty.StringVal("test"),
"region": cty.StringVal("us-west-2"),
"sse_customer_key": cty.StringVal("====CT70aTYB2JGff7AjQtwbiLkwH4npICay1PWtmdka"),
}),
expectedErr: `sse_customer_key must be base64 encoded`,
},
"encyrption key conflict": {
config: cty.ObjectVal(map[string]cty.Value{
"bucket": cty.StringVal("test"),