jprdonnelly/opentf
1
0
Fork 0
mirror of https://github.com/opentffoundation/opentf.git synced 2025-12-25 01:00:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Reduce calls to state DeepCopy() by half during apply (#3011)

Browse Source 
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Co-authored-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Co-authored-by: Martin Atkins <mart@degeneration.co.uk>
This commit is contained in:
Christian Mesh
2025-08-26 14:36:01 -04:00
committed by GitHub
parent 234a8b8deb
commit 928533f1fe
17 changed files with 162 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/backend/local/hook_state.go
View File

@@ -22,7 +22,8 @@ type StateHook struct {
tofu.NilHook
sync.Mutex
StateMgr statemgr.Writer
StateMgr statemgr.Writer
workingCopy *states.SyncState
// If PersistInterval is nonzero then for any new state update after
// the duration has elapsed we'll try to persist a state snapshot
@@ -64,7 +65,7 @@ type IntermediateStatePersistInfo struct {
var _ tofu.Hook = (*StateHook)(nil)
func (h *StateHook) PostStateUpdate(new *states.State) (tofu.HookAction, error) {
func (h *StateHook) PostStateUpdate(mutate func(*states.SyncState)) (tofu.HookAction, error) {
h.Lock()
defer h.Unlock()
@@ -77,9 +78,14 @@ func (h *StateHook) PostStateUpdate(new *states.State) (tofu.HookAction, error)
}
if h.StateMgr != nil {
if err := h.StateMgr.WriteState(new); err != nil {
mutate(h.workingCopy)
if err := h.StateMgr.WriteState(h.workingCopy.Lock()); err != nil {
h.workingCopy.Unlock()
return tofu.HookActionHalt, err
}
h.workingCopy.Unlock()
if mgrPersist, ok := h.StateMgr.(statemgr.Persister); ok && h.PersistInterval != 0 && h.Schemas != nil {
if h.shouldPersist() {
err := mgrPersist.PersistState(context.TODO(), h.Schemas)