jprdonnelly/opentf
1
0
Fork 0
mirror of https://github.com/opentffoundation/opentf.git synced 2025-12-25 01:00:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Support References in Variable Validation (#2216)

Browse Source 
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
This commit is contained in:
Christian Mesh
2024-12-04 14:24:44 -05:00
committed by GitHub
parent 3d51e3c9df
commit f6a1d8e2dd
9 changed files with 337 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
internal/tofu/node_variable_reference.go
View File

@@ -33,11 +33,17 @@ var (
_ GraphNodeReferenceable = (*nodeVariableReference)(nil)
_ GraphNodeReferencer = (*nodeVariableReference)(nil)
_ graphNodeExpandsInstances = (*nodeVariableReference)(nil)
_ graphNodeTemporaryValue = (*nodeVariableReference)(nil)
)
// graphNodeExpandsInstances
func (n *nodeVariableReference) expandsInstances() {}
// Abuse graphNodeTemporaryValue to keep the validation rule around
func (n *nodeVariableReference) temporaryValue() bool {
return len(n.Config.Validations) == 0
}
// GraphNodeDynamicExpandable
func (n *nodeVariableReference) DynamicExpand(ctx EvalContext) (*Graph, error) {
var g Graph
@@ -92,9 +98,9 @@ func (n *nodeVariableReference) References() []*addrs.Reference {
var refs []*addrs.Reference
if n.Config != nil {
for _, validation := range n.Config.Validations {
condFuncs, _ := lang.ProviderFunctionsInExpr(addrs.ParseRef, validation.Condition)
condFuncs, _ := lang.ReferencesInExpr(addrs.ParseRef, validation.Condition)
refs = append(refs, condFuncs...)
errFuncs, _ := lang.ProviderFunctionsInExpr(addrs.ParseRef, validation.ErrorMessage)
errFuncs, _ := lang.ReferencesInExpr(addrs.ParseRef, validation.ErrorMessage)
refs = append(refs, errFuncs...)
}
}
@@ -137,9 +143,22 @@ func (n *nodeVariableReferenceInstance) ModulePath() addrs.Module {
}
// GraphNodeExecutable
func (n *nodeVariableReferenceInstance) Execute(ctx EvalContext, _ walkOperation) tfdiags.Diagnostics {
func (n *nodeVariableReferenceInstance) Execute(ctx EvalContext, op walkOperation) tfdiags.Diagnostics {
log.Printf("[TRACE] nodeVariableReferenceInstance: evaluating %s", n.Addr)
return evalVariableValidations(n.Addr, n.Config, n.Expr, ctx)
diags := evalVariableValidations(n.Addr, n.Config, n.Expr, ctx)
if op == walkValidate {
var filtered tfdiags.Diagnostics
// Validate may contain unknown values, we can ignore that until plan/apply
for _, diag := range diags {
if !tfdiags.DiagnosticCausedByUnknown(diag) {
filtered = append(filtered, diag)
}
}
return filtered
}
return diags
}
// dag.GraphNodeDotter impl.