mirror of
https://github.com/opentffoundation/opentf.git
synced 2026-03-16 01:00:22 -04:00
3a2d73a2b1
snapshot Fixes #6406 Adds 2 new parameters: * `snapshot_identifier` * `snapshot_cluster_identifier` These will be used to allow the Redshift cluster to be restored from a pre-existing snapshot. Also makes the redshift username and password fields optional as these are not required for the snapshot ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRedshiftCluster_' ==> Checking that code complies with gofmt requirements... /Users/stacko/Code/go/bin/stringer go generate $(go list ./... | grep -v /terraform/vendor/) 2016/08/23 12:04:53 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRedshiftCluster_ -timeout 120m === RUN TestAccAWSRedshiftCluster_importBasic --- PASS: TestAccAWSRedshiftCluster_importBasic (741.03s) === RUN TestAccAWSRedshiftCluster_basic --- PASS: TestAccAWSRedshiftCluster_basic (656.33s) === RUN TestAccAWSRedshiftCluster_loggingEnabled --- PASS: TestAccAWSRedshiftCluster_loggingEnabled (718.65s) === RUN TestAccAWSRedshiftCluster_iamRoles --- PASS: TestAccAWSRedshiftCluster_iamRoles (818.10s) === RUN TestAccAWSRedshiftCluster_publiclyAccessible --- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (853.30s) === RUN TestAccAWSRedshiftCluster_updateNodeCount --- PASS: TestAccAWSRedshiftCluster_updateNodeCount (2083.37s) === RUN TestAccAWSRedshiftCluster_tags --- PASS: TestAccAWSRedshiftCluster_tags (621.15s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 6491.963s ``` When deploying this, I was able to use config as follows: ``` resource "aws_redshift_cluster" "restore" { cluster_identifier = "my-test-restored-cluster" snapshot_identifier = "sample-snapshot-for-restore" node_type = "dc1.large" } ``` And it resulted in: ``` terraform apply [WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider. If you did not expect to see this message you will need to remove the old plugin. See https://www.terraform.io/docs/internals/internal-plugins.html aws_redshift_cluster.restore: Creating... allow_version_upgrade: "" => "true" automated_snapshot_retention_period: "" => "1" availability_zone: "" => "<computed>" bucket_name: "" => "<computed>" cluster_identifier: "" => "my-test-restored-cluster" cluster_parameter_group_name: "" => "<computed>" cluster_public_key: "" => "<computed>" cluster_revision_number: "" => "<computed>" cluster_security_groups.#: "" => "<computed>" cluster_subnet_group_name: "" => "<computed>" cluster_type: "" => "<computed>" cluster_version: "" => "1.0" database_name: "" => "<computed>" enable_logging: "" => "false" encrypted: "" => "<computed>" endpoint: "" => "<computed>" iam_roles.#: "" => "<computed>" kms_key_id: "" => "<computed>" node_type: "" => "dc1.large" number_of_nodes: "" => "1" port: "" => "5439" preferred_maintenance_window: "" => "<computed>" publicly_accessible: "" => "true" s3_key_prefix: "" => "<computed>" skip_final_snapshot: "" => "true" snapshot_identifier: "" => "sample-snapshot-for-restore" vpc_security_group_ids.#: "" => "<computed>" .......... aws_redshift_cluster.restore: Still creating... (5m20s elapsed) aws_redshift_cluster.restore: Creation complete Apply complete! Resources: 1 added, 0 changed, 0 destroyed. ```