mirror of
https://github.com/opentffoundation/opentf.git
synced 2026-04-22 03:02:13 -04:00
a1e29ae290
The semver library we were using doesn't have support for a "pessimistic constraint" where e.g. the user wants to accept only minor or patch version upgrades. This is important for providers since users will generally want to pin their dependencies to not inadvertantly accept breaking changes. So here we switch to hashicorp's home-grown go-version library, which has the ~> constraint operator for this sort of constraint. Given how much the old version object was already intruding into the interface and creating dependency noise in callers, this also now wraps the "raw" go-version objects in package-local structs, thus keeping the details encapsulated and allowing callers to deal just with this package's own types.
65 lines
1.4 KiB
Go
65 lines
1.4 KiB
Go
package discovery
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
)
|
|
|
|
func TestVersionSet(t *testing.T) {
|
|
tests := []struct {
|
|
ConstraintStr string
|
|
VersionStr string
|
|
ShouldHave bool
|
|
}{
|
|
// These test cases are not exhaustive since the underlying go-version
|
|
// library is well-tested. This is mainly here just to exercise our
|
|
// wrapper code, but also used as an opportunity to cover some basic
|
|
// but important cases such as the ~> constraint so that we'll be more
|
|
// likely to catch any accidental breaking behavior changes in the
|
|
// underlying library.
|
|
{
|
|
">=1.0.0",
|
|
"1.0.0",
|
|
true,
|
|
},
|
|
{
|
|
">=1.0.0",
|
|
"0.0.0",
|
|
false,
|
|
},
|
|
{
|
|
">=1.0.0",
|
|
"1.1.0-beta1",
|
|
true,
|
|
},
|
|
{
|
|
"~>1.1.0",
|
|
"1.1.2-beta1",
|
|
true,
|
|
},
|
|
{
|
|
"~>1.1.0",
|
|
"1.2.0",
|
|
false,
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(fmt.Sprintf("%s has %s", test.ConstraintStr, test.VersionStr), func(t *testing.T) {
|
|
accepted, err := ConstraintStr(test.ConstraintStr).Parse()
|
|
if err != nil {
|
|
t.Fatalf("unwanted error parsing constraints string %q: %s", test.ConstraintStr, err)
|
|
}
|
|
|
|
version, err := VersionStr(test.VersionStr).Parse()
|
|
if err != nil {
|
|
t.Fatalf("unwanted error parsing version string %q: %s", test.VersionStr, err)
|
|
}
|
|
|
|
if got, want := accepted.Has(version), test.ShouldHave; got != want {
|
|
t.Errorf("Has returned %#v; want %#v", got, want)
|
|
}
|
|
})
|
|
}
|
|
}
|