mirror of
https://github.com/opentffoundation/opentf.git
synced 2026-03-23 04:00:32 -04:00
We don't typically just broadly run automatic rewriting tools like "go fix" across our codebase because that tends to cause annoying and unnecessary merge conflicts when we're backporting to earlier release branches. But all of the files in this commit were changed in some non-trivial way already during the OpenTofu v1.11 development period anyway, and so the likelyhood we'd be able to successfully backport from them is reduced and therefore this seems like a good opportunity to do some focused modernization using "go fix". My rules for what to include or not are admittedly quite "vibes-based", but the general idea was: - Focusing on files under the "command" directory only, because that's already been an area of intentional refactoring during this development period. - If the existing diff in a file is already significantly larger than the changes the fixer proposed to make, or if the fixer is proposing to change a line that was already changed in this development period. - More willing to include "_test.go" files than non-test files, even if they hadn't changed as much already, just because backports from test files for bug fixes tend to be entirely new test cases more than they are modifications to existing test cases, and so the risk of conflicts is lower there. Signed-off-by: Martin Atkins <mart@degeneration.co.uk>
141 lines
4.3 KiB
Go
141 lines
4.3 KiB
Go
// Copyright (c) The OpenTofu Authors
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
// Copyright (c) 2023 HashiCorp, Inc.
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
|
|
package e2etest
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/opentofu/opentofu/internal/e2e"
|
|
"github.com/opentofu/opentofu/internal/getproviders"
|
|
)
|
|
|
|
// TestProviderProtocols verifies that OpenTofu can execute provider plugins
|
|
// with both supported protocol versions.
|
|
func TestProviderProtocols(t *testing.T) {
|
|
if !canRunGoBuild {
|
|
// We're running in a separate-build-then-run context, so we can't
|
|
// currently execute this test which depends on being able to build
|
|
// new executable at runtime.
|
|
//
|
|
// (See the comment on canRunGoBuild's declaration for more information.)
|
|
t.Skip("can't run without building a new provider executable")
|
|
}
|
|
t.Parallel()
|
|
|
|
tf := e2e.NewBinary(t, tofuBin, "testdata/provider-plugin")
|
|
|
|
// In order to do a decent end-to-end test for this case we will need a real
|
|
// enough provider plugin to try to run and make sure we are able to
|
|
// actually run it. Here will build the simple and simple6 (built with
|
|
// protocol v6) providers.
|
|
simple6Provider := filepath.Join(tf.WorkDir(), "terraform-provider-simple6")
|
|
simple6ProviderExe := e2e.GoBuild("github.com/opentofu/opentofu/internal/provider-simple-v6/main", simple6Provider)
|
|
|
|
simpleProvider := filepath.Join(tf.WorkDir(), "terraform-provider-simple")
|
|
simpleProviderExe := e2e.GoBuild("github.com/opentofu/opentofu/internal/provider-simple/main", simpleProvider)
|
|
|
|
extension := ""
|
|
if runtime.GOOS == "windows" {
|
|
extension = ".exe"
|
|
}
|
|
|
|
// Move the provider binaries into a directory that we will point tofu
|
|
// to using the -plugin-dir cli flag.
|
|
platform := getproviders.CurrentPlatform.String()
|
|
hashiDir := "cache/registry.opentofu.org/hashicorp/"
|
|
if err := os.MkdirAll(tf.Path(hashiDir, "simple6/0.0.1/", platform), os.ModePerm); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.Rename(simple6ProviderExe, tf.Path(hashiDir, "simple6/0.0.1/", platform, "terraform-provider-simple6")+extension); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := os.MkdirAll(tf.Path(hashiDir, "simple/0.0.1/", platform), os.ModePerm); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.Rename(simpleProviderExe, tf.Path(hashiDir, "simple/0.0.1/", platform, "terraform-provider-simple")+extension); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
//// INIT
|
|
_, stderr, err := tf.Run("init", "-plugin-dir=cache")
|
|
if err != nil {
|
|
t.Fatalf("unexpected init error: %s\nstderr:\n%s", err, stderr)
|
|
}
|
|
|
|
//// PLAN
|
|
_, stderr, err = tf.Run("plan", "-out=tfplan")
|
|
if err != nil {
|
|
t.Fatalf("unexpected plan error: %s\nstderr:\n%s", err, stderr)
|
|
}
|
|
|
|
//// APPLY
|
|
stdout, stderr, err := tf.Run("apply", "tfplan")
|
|
if err != nil {
|
|
t.Fatalf("unexpected apply error: %s\nstderr:\n%s", err, stderr)
|
|
}
|
|
|
|
if !strings.Contains(stdout, "Apply complete! Resources: 2 added, 0 changed, 0 destroyed.") {
|
|
t.Fatalf("wrong output:\nstdout:%s\nstderr%s", stdout, stderr)
|
|
}
|
|
|
|
/// DESTROY
|
|
stdout, stderr, err = tf.Run("destroy", "-auto-approve")
|
|
if err != nil {
|
|
t.Fatalf("unexpected apply error: %s\nstderr:\n%s", err, stderr)
|
|
}
|
|
|
|
if !strings.Contains(stdout, "Resources: 2 destroyed") {
|
|
t.Fatalf("wrong destroy output\nstdout:%s\nstderr:%s", stdout, stderr)
|
|
}
|
|
}
|
|
|
|
// This test is designed to simulate a *very* busy CI server that has multiple
|
|
// processes sharing a global provider cache. This exercises the locking in the
|
|
// "providercache" package, as well as simulating bad file hashes in the
|
|
// lock file.
|
|
func TestProviderGlobalCache(t *testing.T) {
|
|
if !canAccessNetwork() {
|
|
t.Skip("Requires provider download access for e2e provider interactions")
|
|
}
|
|
|
|
t.Parallel()
|
|
|
|
tmpDir, err := filepath.EvalSymlinks(t.TempDir())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
rcLoc := filepath.Join(tmpDir, ".tofurc")
|
|
// We use forward slashes consistently, even on Windows, because backslashes
|
|
// require escaping for valid HCL syntax.
|
|
rcData := fmt.Sprintf(`plugin_cache_dir = "%s"`, filepath.ToSlash(tmpDir))
|
|
err = os.WriteFile(rcLoc, []byte(rcData), 0600)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var wg sync.WaitGroup
|
|
|
|
for range 16 {
|
|
wg.Go(func() {
|
|
tf := e2e.NewBinary(t, tofuBin, "testdata/provider-global-cache")
|
|
tf.AddEnv(fmt.Sprintf("TF_CLI_CONFIG_FILE=%s", rcLoc))
|
|
|
|
stdout, stderr, err := tf.Run("init")
|
|
tofuResult{t, stdout, stderr, err}.Success()
|
|
})
|
|
}
|
|
|
|
wg.Wait()
|
|
}
|