mirror of
https://github.com/opentffoundation/opentf.git
synced 2026-03-21 16:00:41 -04:00
9b35d84dd1
There is currently a bug in the apply engine that's causing a self-dependency error during promise resolution, which was a good reminder that we'd not previously finished connecting all of the parts to be able to unwind such problems into a useful error message. Due to how the work is split between the apply engine, the evaluator, and the execgraph package it takes some awkward back-and-forth to get all of the needed information together into one place. This compromise aims to do as little work as possible in the happy path and defer more expensive analysis until we actually know we're going to report an error message. In this case we can't really avoid proactively collecting the request IDs because we don't know ahead of time what (if anything) will be involved in a promise error, but only when actually generating an error message will we dig into the original source execution graph to find out what each of the affected requests was actually trying to do and construct a human-friendly summary of each one. This was a bit of a side-quest relative to the current goal of just getting things basically working with a simple configuration, but this is useful in figuring out what's going on with the current bug (which will be fixed in a future commit) and will probably be useful when dealing with future bugs too. Signed-off-by: Martin Atkins <mart@degeneration.co.uk>
78 lines
2.7 KiB
Go
78 lines
2.7 KiB
Go
// Copyright (c) The OpenTofu Authors
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
// Copyright (c) 2023 HashiCorp, Inc.
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
|
|
package applying
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/zclconf/go-cty/cty"
|
|
|
|
"github.com/opentofu/opentofu/internal/addrs"
|
|
"github.com/opentofu/opentofu/internal/engine/internal/execgraph"
|
|
"github.com/opentofu/opentofu/internal/engine/plugins"
|
|
"github.com/opentofu/opentofu/internal/lang/eval"
|
|
"github.com/opentofu/opentofu/internal/lang/grapheval"
|
|
"github.com/opentofu/opentofu/internal/plans"
|
|
"github.com/opentofu/opentofu/internal/states"
|
|
"github.com/opentofu/opentofu/internal/tfdiags"
|
|
)
|
|
|
|
// ApplyPlannedChanges is a temporary placeholder entrypoint for a new approach
|
|
// to applying based on an execution graph generated during the planning phase.
|
|
//
|
|
// The signature here is a little confusing because we're currently reusing
|
|
// our old-style plan and state models, even though their shape isn't quite
|
|
// right for what we need here. A future version of this function will hopefully
|
|
// have a signature more tailored to the needs of the new apply engine, once
|
|
// we have a stronger understanding of what those needs are.
|
|
func ApplyPlannedChanges(ctx context.Context, plan *plans.Plan, configInst *eval.ConfigInstance, plugins plugins.Plugins) (*states.State, tfdiags.Diagnostics) {
|
|
var diags tfdiags.Diagnostics
|
|
|
|
glue := &evalGlue{
|
|
plugins: plugins,
|
|
// graph field populated below before we actually use the oracle
|
|
// during graph execution.
|
|
}
|
|
oracle, moreDiags := configInst.ApplyOracle(ctx, glue)
|
|
diags = diags.Append(moreDiags)
|
|
if moreDiags.HasErrors() {
|
|
return nil, diags
|
|
}
|
|
|
|
execGraphSrc, execGraph, execOps, moreDiags := compileExecutionGraph(ctx, plan, oracle, plugins)
|
|
diags = diags.Append(moreDiags)
|
|
if moreDiags.HasErrors() {
|
|
return nil, diags
|
|
}
|
|
glue.graph = execGraph
|
|
|
|
reqTracker := newRequestTracker(execGraphSrc, execOps)
|
|
ctx = grapheval.ContextWithRequestTracker(ctx, reqTracker)
|
|
|
|
moreDiags = execGraph.Execute(ctx)
|
|
diags = diags.Append(moreDiags)
|
|
|
|
newState, moreDiags := execOps.Finish(ctx)
|
|
diags = diags.Append(moreDiags)
|
|
|
|
return newState, diags
|
|
}
|
|
|
|
type evalGlue struct {
|
|
graph *execgraph.CompiledGraph
|
|
plugins plugins.Plugins
|
|
}
|
|
|
|
// ResourceInstanceFinalState implements [eval.ApplyGlue].
|
|
func (e *evalGlue) ResourceInstanceFinalState(ctx context.Context, addr addrs.AbsResourceInstance) cty.Value {
|
|
return e.graph.ResourceInstanceValue(ctx, addr)
|
|
}
|
|
|
|
// ValidateProviderConfig implements [eval.ApplyGlue].
|
|
func (e *evalGlue) ValidateProviderConfig(ctx context.Context, provider addrs.Provider, configVal cty.Value) tfdiags.Diagnostics {
|
|
return e.plugins.ValidateProviderConfig(ctx, provider, configVal)
|
|
}
|