Mikel Olasagasti Uranga 66765bdab3 Fix: Ensure constant format strings in fmt and printf calls ...

Go 1.24 introduces stricter checks for format string validation.
This commit fixes instances where non-constant format strings were
used in calls to functions like `fmt.Errorf`, `fmt.Printf`, and similar.

Changes include:
- Replacing dynamically constructed strings passed as format strings
with constant format strings.
- Refactoring `fmt.Sprintf` calls to ensure the format string matches
the number of arguments provided.
- Simplifying redundant formatting and ensuring compliance with Go
1.24's stricter `vet` tool checks.

This update ensures compatibility with Go 1.24 and prevents potential
runtime errors caused by misinterpreted dynamic format strings.

Resolves #2389

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
Co-authored-by: Martin Atkins <mart@degeneration.co.uk>
Signed-off-by: Martin Atkins <mart@degeneration.co.uk>

2025-02-26 11:33:43 -08:00

..

testdata

MakeStaticTimestampFunc now returns unknown value if the given time.Time is zero (#2413)

2025-01-27 17:07:40 +02:00

bench_many_instances_test.go

tofu: Some benchmarks for situations with many instances

2025-02-19 08:15:29 -08:00

context_apply2_test.go

Fix: Ensure constant format strings in fmt and printf calls

2025-02-26 11:33:43 -08:00

context_apply_checks_test.go

tofu: Context.Apply now takes a context.Context

2024-11-19 10:15:21 -08:00

context_apply_test.go

Fix: Ensure constant format strings in fmt and printf calls

2025-02-26 11:33:43 -08:00

context_apply.go

Add count of forgotten resources to plan and apply outputs. (#2010)

2025-02-24 14:53:32 -05:00

context_eval_test.go

tofu: Context.Eval now takes a context.Context

2024-11-19 10:15:21 -08:00

context_eval.go

tofu: context.Context plumbed into the graph walk driver

2024-11-19 10:15:21 -08:00

context_fixtures_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

context_functions_test.go

Split variable evaluation / validation scope (#2199)

2024-12-02 09:18:07 -05:00

context_functions.go

Fix provider functions in child modules (#2082)

2024-10-23 10:42:38 -04:00

context_import_test.go

tofu: Context.Import now takes a context.Context

2024-11-19 10:15:21 -08:00

context_import.go

evalchecks: Suggest -exclude as a workaround for unknown count/for_each

2025-01-02 13:24:11 -08:00

context_input_test.go

tofu: Context.Input now takes a context.Context

2024-11-19 10:15:21 -08:00

context_input.go

Temporarily disable the complexity-related lint rules

2025-01-03 10:41:05 -05:00

context_plan2_test.go

Moved for different types (#2370)

2025-02-05 15:14:19 +04:00

context_plan_test.go

Fix: Ensure constant format strings in fmt and printf calls

2025-02-26 11:33:43 -08:00

context_plan.go

Moved for different types (#2370)

2025-02-05 15:14:19 +04:00

context_plugins_test.go

Cleanup ContextPlugins after function changes (#1550)

2024-04-25 07:19:15 -04:00

context_plugins.go

Cleanup ContextPlugins after function changes (#1550)

2024-04-25 07:19:15 -04:00

context_refresh_test.go

tofu: Context.Validate now takes a context.Context

2024-11-19 10:15:21 -08:00

context_refresh.go

tofu: Context.Refresh now takes a context.Context

2024-11-19 10:15:21 -08:00

context_test.go

tofu+configload: Test utilities take testing.TB

2025-02-19 08:15:29 -08:00

context_validate_test.go

MakeStaticTimestampFunc now returns unknown value if the given time.Time is zero (#2413)

2025-01-27 17:07:40 +02:00

context_validate.go

tofu: context.Context plumbed into the graph walk driver

2024-11-19 10:15:21 -08:00

context_walk.go

tofu: context.Context plumbed into the graph walk driver

2024-11-19 10:15:21 -08:00

context.go

Add a new warning when a provider cannot be downloaded and it was requested by an implicit usage (#2479)

2025-02-12 18:40:54 +02:00

eval_conditions.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

eval_context_builtin_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

eval_context_builtin.go

Compare ModuleInstance to Module without allocating, and similar (#2261)

2024-12-12 12:47:57 -05:00

eval_context_mock.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

eval_context.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

eval_count_test.go

evalchecks: Suggest -exclude as a workaround for unknown count/for_each

2025-01-02 13:24:11 -08:00

eval_expansion.go

tofu: eval_iteration.go is now eval_expansion.go

2025-01-02 13:24:11 -08:00

eval_import_test.go

Support for_each syntax in import block (#1492)

2024-04-17 17:12:10 +03:00

eval_import.go

300/provider foreach (#1911)

2024-09-06 14:33:05 +01:00

eval_provider_test.go

Partial revert of #1911, support provider for_each in aliases (#2121)

2024-11-05 06:19:52 -05:00

eval_provider.go

Local values can now be used in provider key expressions (#2280)

2024-12-11 07:46:40 -05:00

eval_variable_test.go

Support References in Variable Validation (#2216)

2024-12-04 14:24:44 -05:00

eval_variable.go

Support References in Variable Validation (#2216)

2024-12-04 14:24:44 -05:00

evaluate_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

evaluate_triggers_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

evaluate_triggers.go

Another batch of minor typos (#1953)

2024-09-09 07:51:39 -04:00

evaluate_valid_test.go

Integrate provider functions (#1439)

2024-04-10 08:04:08 -04:00

evaluate_valid.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

evaluate.go

Fix typos (#1905)

2024-08-29 13:20:33 -04:00

execute.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

features.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

graph_builder_apply_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

graph_builder_apply.go

fix: unused config's create_before_destroy on resource change with no refresh (#2248)

2024-12-20 10:47:00 +02:00

graph_builder_eval.go

Fix provider functions in child modules (#2082)

2024-10-23 10:42:38 -04:00

graph_builder_plan_test.go

Split variable evaluation / validation scope (#2199)

2024-12-02 09:18:07 -05:00

graph_builder_plan.go

Add exclude flag support (#1900)

2024-11-05 10:16:00 -05:00

graph_builder_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

graph_builder.go

Only call StringWithNodeTypes for TRACE logs (#1810)

2024-07-24 13:44:20 -04:00

graph_dot_test.go

Error handling fixes (#1816)

2024-07-15 11:58:43 +02:00

graph_dot.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

graph_interface_subgraph.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

graph_test.go

Another batch of minor typos (#1953)

2024-09-09 07:51:39 -04:00

graph_walk_context.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

graph_walk_operation.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

graph_walk_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

graph_walk.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

graph.go

tofu: context.Context plumbed into the graph walk driver

2024-11-19 10:15:21 -08:00

hook_mock.go

Add count of forgotten resources to plan and apply outputs. (#2010)

2025-02-24 14:53:32 -05:00

hook_stop_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

hook_stop.go

Add count of forgotten resources to plan and apply outputs. (#2010)

2025-02-24 14:53:32 -05:00

hook_test.go

Add count of forgotten resources to plan and apply outputs. (#2010)

2025-02-24 14:53:32 -05:00

hook.go

Add count of forgotten resources to plan and apply outputs. (#2010)

2025-02-24 14:53:32 -05:00

instance_expanders.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

marks_test.go

Improve comparison of sensitive marks on resources, and propagate the sensitive_attributes correctly (#1640)

2024-07-09 08:42:02 -04:00

marks.go

Improve comparison of sensitive marks on resources, and propagate the sensitive_attributes correctly (#1640)

2024-07-09 08:42:02 -04:00

node_check.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

node_data_destroy_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

node_data_destroy.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

node_external_reference.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

node_local_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

node_local.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

node_module_expand_test.go

add override implementation for testing framework (#1499)

2024-06-06 13:20:41 +03:00

node_module_expand.go

evalchecks: Suggest -exclude as a workaround for unknown count/for_each

2025-01-02 13:24:11 -08:00

node_module_variable_test.go

tofu: Context.Apply now takes a context.Context

2024-11-19 10:15:21 -08:00

node_module_variable.go

Split variable evaluation / validation scope (#2199)

2024-12-02 09:18:07 -05:00

node_output_test.go

refactor sensitive marks usage (#2503)

2025-02-11 19:02:21 +02:00

node_output.go

refactor sensitive marks usage (#2503)

2025-02-11 19:02:21 +02:00

node_provider_abstract.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

node_provider_eval.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

node_provider_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

node_provider.go

Improve log messages for providers with keys (#2152)

2024-11-07 11:56:21 -05:00

node_resource_abstract_instance_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

node_resource_abstract_instance.go

fix: provider not initialized in some cases (mostly, deposed) (#2335)

2025-01-08 12:34:52 -05:00

node_resource_abstract_test.go

Moved for different types (#2370)

2025-02-05 15:14:19 +04:00

node_resource_abstract.go

Moved for different types (#2370)

2025-02-05 15:14:19 +04:00

node_resource_apply_instance.go

fix: provider not initialized in some cases (mostly, deposed) (#2335)

2025-01-08 12:34:52 -05:00

node_resource_apply_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

node_resource_apply.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

node_resource_deposed_test.go

Compare ModuleInstance to Module without allocating, and similar (#2261)

2024-12-12 12:47:57 -05:00

node_resource_deposed.go

fix: provider not initialized in some cases (mostly, deposed) (#2335)

2025-01-08 12:34:52 -05:00

node_resource_destroy.go

fix: provider not initialized in some cases (mostly, deposed) (#2335)

2025-01-08 12:34:52 -05:00

node_resource_forget.go

fix: provider not initialized in some cases (mostly, deposed) (#2335)

2025-01-08 12:34:52 -05:00

node_resource_import.go

fix: provider not initialized in some cases (mostly, deposed) (#2335)

2025-01-08 12:34:52 -05:00

node_resource_plan_destroy.go

fix: provider not initialized in some cases (mostly, deposed) (#2335)

2025-01-08 12:34:52 -05:00

node_resource_plan_instance.go

fix: provider not initialized in some cases (mostly, deposed) (#2335)

2025-01-08 12:34:52 -05:00

node_resource_plan_orphan_test.go

Compare ModuleInstance to Module without allocating, and similar (#2261)

2024-12-12 12:47:57 -05:00

node_resource_plan_orphan.go

fix: provider not initialized in some cases (mostly, deposed) (#2335)

2025-01-08 12:34:52 -05:00

node_resource_plan.go

Skip imports on tofu destroy (#2214)

2024-11-25 23:52:03 +02:00

node_resource_validate_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

node_resource_validate.go

evalchecks: Suggest -exclude as a workaround for unknown count/for_each

2025-01-02 13:24:11 -08:00

node_root_variable_test.go

Split variable evaluation / validation scope (#2199)

2024-12-02 09:18:07 -05:00

node_root_variable.go

Split variable evaluation / validation scope (#2199)

2024-12-02 09:18:07 -05:00

node_value.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

node_variable_reference.go

Support References in Variable Validation (#2216)

2024-12-04 14:24:44 -05:00

opentf_test.go

tofu+configload: Test utilities take testing.TB

2025-02-19 08:15:29 -08:00

phasestate_string.go

Rename opentf package to tofu (#466)

2023-09-20 15:16:53 +03:00

provider_for_test_framework.go

Moved for different types (#2370)

2025-02-05 15:14:19 +04:00

provider_mock.go

Moved for different types (#2370)

2025-02-05 15:14:19 +04:00

provisioner_mock_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

provisioner_mock.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

reduce_plan_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

reduce_plan.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

resource_provider_mock_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

schemas_test.go

Cleanup ContextPlugins after function changes (#1550)

2024-04-25 07:19:15 -04:00

schemas.go

Fix typos (#1905)

2024-08-29 13:20:33 -04:00

test_context_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

test_context.go

Fix provider functions in child modules (#2082)

2024-10-23 10:42:38 -04:00

transform_attach_config_provider_meta.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_attach_config_provider.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_attach_config_resource_test.go

add automated copyright header check (#1696)

2024-06-03 16:49:36 +03:00

transform_attach_config_resource.go

Improve performance of AttachResourceConfigTransformer on big graphs (#1558)

2024-04-29 11:36:54 -04:00

transform_attach_schema.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_attach_state.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_check_starter.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_check.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_config_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_config.go

add override implementation for testing framework (#1499)

2024-06-06 13:20:41 +03:00

transform_destroy_cbd_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

transform_destroy_cbd.go

fix: unused config's create_before_destroy on resource change with no refresh (#2248)

2024-12-20 10:47:00 +02:00

transform_destroy_edge_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

transform_destroy_edge.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

transform_diff_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_diff.go

Add support for removed block (#1158)

2024-02-21 10:31:44 +02:00

transform_expand.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_external_reference.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_import_state_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

transform_local.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_module_expansion_test.go

Improve ModuleExpansionTransformer performance (#1809)

2024-07-29 15:55:37 -04:00

transform_module_expansion.go

Improve ModuleExpansionTransformer performance (#1809)

2024-07-29 15:55:37 -04:00

transform_module_variable_test.go

Split variable evaluation / validation scope (#2199)

2024-12-02 09:18:07 -05:00

transform_module_variable.go

Split variable evaluation / validation scope (#2199)

2024-12-02 09:18:07 -05:00

transform_orphan_count_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

transform_orphan_count.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_orphan_output.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_orphan_resource_test.go

Implement Provider for_each (#2105)

2024-11-05 18:08:23 -05:00

transform_orphan_resource.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_output.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_provider_test.go

Add exclude flag support (#1900)

2024-11-05 10:16:00 -05:00

transform_provider.go

Split variable evaluation / validation scope (#2199)

2024-12-02 09:18:07 -05:00

transform_provisioner.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_reference_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_reference.go

chore: fix some function names (#2108)

2024-10-29 12:07:10 +02:00

transform_removed_modules.go

Compare ModuleInstance to Module without allocating, and similar (#2261)

2024-12-12 12:47:57 -05:00

transform_resource_count.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_root_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_root.go

add override implementation for testing framework (#1499)

2024-06-06 13:20:41 +03:00

transform_state.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_targets_test.go

Add exclude flag support (#1900)

2024-11-05 10:16:00 -05:00

transform_targets.go

Add exclude flag support (#1900)

2024-11-05 10:16:00 -05:00

transform_transitive_reduction_test.go

Integrate provider functions (#1439)

2024-04-10 08:04:08 -04:00

transform_transitive_reduction.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_variable.go

Split variable evaluation / validation scope (#2199)

2024-12-02 09:18:07 -05:00

transform_vertex_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform_vertex.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

transform.go

Only call StringWithNodeTypes for TRACE logs (#1810)

2024-07-24 13:44:20 -04:00

ui_input_mock.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_input_prefix_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_input_prefix.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_input.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_output_callback_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_output_callback.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_output_mock_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_output_mock.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_output_provisioner_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_output_provisioner.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

ui_output.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

update_state_hook_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

update_state_hook.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

upgrade_resource_state_test.go

Moved for different types (#2370)

2025-02-05 15:14:19 +04:00

upgrade_resource_state.go

Moved for different types (#2370)

2025-02-05 15:14:19 +04:00

util_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

util.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

validate_selfref_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

validate_selfref.go

Fix typos (#1905)

2024-08-29 13:20:33 -04:00

valuesourcetype_string.go

Rename opentf package to tofu (#466)

2023-09-20 15:16:53 +03:00

variables_test.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

variables.go

Another batch of minor typos (#1953)

2024-09-09 07:51:39 -04:00

version_required.go

Update copyright notice (#1232)

2024-02-08 09:48:59 +00:00

walkoperation_string.go

Rename opentf package to tofu (#466)

2023-09-20 15:16:53 +03:00