mirror of
https://github.com/opentffoundation/opentf.git
synced 2026-05-16 16:01:49 -04:00
30db471ac0
The upstream libraries we use to implement this feature are in various states of unmaintained-ness where we've not been able to upgrade them beyond the old versions we're currently using without them no longer working well together. Therefore we previously made this connection type produce a deprecation warning in OpenTofu v1.12, and now we're making it produce an error instead and so we can remove all of our code that was calling in to those dependencies. Although this is a breaking change, we're justifying it under the "external dependencies" pragmatic exception in our compatibility promises: external software has changed in a way that makes it no longer viable to offer this feature. Modern Windows has built-in support for running an OpenSSH server, and so we expect that most folks who were previously relying on WinRM should be able to migrate to using SSH instead. Signed-off-by: Martin Atkins <mart@degeneration.co.uk>
113 lines
2.2 KiB
Go
113 lines
2.2 KiB
Go
// Copyright (c) The OpenTofu Authors
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
// Copyright (c) 2023 HashiCorp, Inc.
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
|
|
package communicator
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"io"
|
|
"net"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/zclconf/go-cty/cty"
|
|
)
|
|
|
|
func TestCommunicator_new(t *testing.T) {
|
|
cfg := map[string]cty.Value{
|
|
"type": cty.StringVal("telnet"),
|
|
"host": cty.StringVal("127.0.0.1"),
|
|
}
|
|
|
|
if _, err := New(cty.ObjectVal(cfg)); err == nil {
|
|
t.Fatalf("expected error with telnet")
|
|
}
|
|
|
|
cfg["type"] = cty.StringVal("ssh")
|
|
if _, err := New(cty.ObjectVal(cfg)); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
cfg["type"] = cty.StringVal("winrm")
|
|
if _, err := New(cty.ObjectVal(cfg)); err == nil {
|
|
t.Fatalf("unexpected success for 'winrm', which is no longer supported")
|
|
}
|
|
}
|
|
|
|
func TestRetryFunc(t *testing.T) {
|
|
origMax := maxBackoffDelay
|
|
maxBackoffDelay = time.Second
|
|
origStart := initialBackoffDelay
|
|
initialBackoffDelay = 10 * time.Millisecond
|
|
|
|
defer func() {
|
|
maxBackoffDelay = origMax
|
|
initialBackoffDelay = origStart
|
|
}()
|
|
|
|
// succeed on the third try
|
|
errs := []error{io.EOF, &net.OpError{Err: errors.New("ERROR")}, nil}
|
|
count := 0
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
|
|
defer cancel()
|
|
|
|
err := Retry(ctx, func() error {
|
|
if count >= len(errs) {
|
|
return errors.New("failed to stop after nil error")
|
|
}
|
|
|
|
err := errs[count]
|
|
count++
|
|
|
|
return err
|
|
})
|
|
|
|
if count != 3 {
|
|
t.Fatal("retry func should have been called 3 times")
|
|
}
|
|
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestRetryFuncBackoff(t *testing.T) {
|
|
origMax := maxBackoffDelay
|
|
maxBackoffDelay = time.Second
|
|
origStart := initialBackoffDelay
|
|
initialBackoffDelay = 100 * time.Millisecond
|
|
|
|
retryTestWg = &sync.WaitGroup{}
|
|
retryTestWg.Add(1)
|
|
|
|
defer func() {
|
|
maxBackoffDelay = origMax
|
|
initialBackoffDelay = origStart
|
|
retryTestWg = nil
|
|
}()
|
|
|
|
count := 0
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
|
|
defer cancel()
|
|
|
|
err := Retry(ctx, func() error {
|
|
count++
|
|
return io.EOF
|
|
})
|
|
if !errors.Is(err, io.EOF) {
|
|
t.Fatal(err)
|
|
}
|
|
cancel()
|
|
retryTestWg.Wait()
|
|
|
|
if count > 4 {
|
|
t.Fatalf("retry func failed to backoff. called %d times", count)
|
|
}
|
|
}
|