mirror of
https://github.com/opentffoundation/opentf.git
synced 2026-05-12 03:02:29 -04:00
bcdadc80ee
Previously we treated PackageLocation only as pure data, describing a location from which something could be retrieved. Unexported functions in package providercache then treated PackageLocation values as a closed union dispatched using a type switch. That strategy has been okay for our relatively-generic package locations so far, but in a future commit we intend to add a new kind of package location referring to a manifest in an OCI distribution repository, and installing from _that_ will require a nontrivial amount of OCI-distribution-specific logic that will be more tightly coupled to the getproviders.Source that will return such locations, and so we're switching to a model where _the location object itself_ is responsible for knowing how to install a provider package from its location, as a method of PackageLocation. The implementation of installing from each location type now moves from package providercache to package getproviders, which is arguably a better thematic home for that functionality anyway. For now these remain tested only indirectly through the tests in package providercache, since we didn't previously have any independent tests for these unexported functions. We might want to add more tightly-scoped unit tests for these to package getproviders in future, but for now this is not materially worse than it was before. Signed-off-by: Martin Atkins <mart@degeneration.co.uk>