jprdonnelly/pyscript
1
0
Fork 0
mirror of https://github.com/pyscript/pyscript.git synced 2025-12-22 19:53:00 -05:00
Code Issues Projects Releases Wiki Activity

Bring tests to next (#1657)

Browse Source 
* bring Makefile to root folder

* add back the print to console when pyscript is ready

* fix build path on tests, link to core.js and overall timeout since it now loads faster

* fix and mark some tests accordingly

* change default timeout to 20s

* review tests and skip what is a known regression

* more tests review until pycondif and skip what is a known regression

* fix pyodide version used on tests

* remove display from config test since it's not testing anything more than console already tests and display as its own tests

* disable config tests that rely on the banner

* skip REPL tests since it's not included in pyscript NEXT

* skip PyTerminal tests since it's not included in pyscript NEXT

* skip more tests relying on Element

* Fix wrong script type from py-script to py

* review more tests related to attributes and add test for worker

* skip spashscreen tests

* wrap up reviews on remaining tests

* update core

* update display tests to use import

* fix more tests and skip some that have known issues

* skip other 2 tests that fail because the test framework injects values that cause the config to fail

* fix getPySrc test due to changed interface

* another round of fixes and commenting on specific tests

---------

Co-authored-by: Fabio Pliger <fpliger@anaconda.com>
This commit is contained in:
Fabio Pliger
2023-09-01 10:01:09 -07:00
committed by GitHub
parent ef44df5dda
commit 12428c0617
22 changed files with 451 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
pyscriptjs/tests/integration/test_01_basic.py
View File

@@ -2,7 +2,7 @@ import re
import pytest
from .support import PyScriptTest, skip_worker
from .support import PyScriptTest
class TestBasic(PyScriptTest):
@@ -17,6 +17,11 @@ class TestBasic(PyScriptTest):
)
assert self.console.log.lines == ["hello pyscript"]
# TODO: I think this test actually should test that we don't load anything if there aren't
# any pyscrpt related tags or features. Meaning that the Platform is not invasive.
@pytest.mark.skip(
reason="DIFFERENT BEHAVIOUR: We don't print anything in the console once loaded"
)
def test_execution_thread(self):
self.pyscript_run(
"""
@@ -26,12 +31,15 @@ class TestBasic(PyScriptTest):
)
assert self.execution_thread in ("main", "worker")
if self.execution_thread == "main":
where = "the main thread"
pass
elif self.execution_thread == "worker":
where = "a web worker"
expected = f"[pyscript/main] Starting the interpreter in {where}"
pass
expected = ("[pyscript/main] PyScript Ready",)
assert expected in self.console.info.lines
@pytest.mark.skip(
reason="FIXME: No banner and should also add a WARNING about CORS"
)
def test_no_cors_headers(self):
self.disable_cors_headers()
self.pyscript_run(
@@ -66,6 +74,7 @@ class TestBasic(PyScriptTest):
)
assert self.console.log.lines[-1] == "hello pyscript"
@pytest.mark.skip("FIXME: No banner")
def test_python_exception(self):
self.pyscript_run(
"""
@@ -80,8 +89,7 @@ class TestBasic(PyScriptTest):
#
# check that we sent the traceback to the console
tb_lines = self.console.error.lines[-1].splitlines()
assert tb_lines[0] == "[pyexec] Python exception:"
assert tb_lines[1] == "Traceback (most recent call last):"
assert tb_lines[0] == "Python Error: Traceback (most recent call last):"
assert tb_lines[-1] == "Exception: this is an error"
#
# check that we show the traceback in the page. Note that here we
@@ -93,12 +101,13 @@ class TestBasic(PyScriptTest):
assert tb_lines[0] == "Traceback (most recent call last):"
assert tb_lines[-1] == "Exception: this is an error"
@pytest.mark.skip(reason="FIX TEST: Works on CHROME")
def test_python_exception_in_event_handler(self):
self.pyscript_run(
"""
<button py-click="onclick()">Click me</button>
<button py-click="onclick">Click me</button>
<py-script>
def onclick():
def onclick(event):
raise Exception("this is an error inside handler")
</py-script>
"""
@@ -142,6 +151,7 @@ class TestBasic(PyScriptTest):
"four",
]
@pytest.mark.skip(reason="FIXME: log('<div></div>') now logs an empty string.")
def test_escaping_of_angle_brackets(self):
"""
Check that py-script tags escape angle brackets
@@ -155,12 +165,11 @@ class TestBasic(PyScriptTest):
assert self.console.log.lines[-2:] == ["true false", "<div></div>"]
@pytest.mark.skip(reason="FIX TEST: Works on CHROME")
def test_packages(self):
self.pyscript_run(
"""
<py-config>
# we use asciitree because it's one of the smallest packages
# which are built and distributed with pyodide
packages = ["asciitree"]
</py-config>
<py-script>
@@ -177,7 +186,7 @@ class TestBasic(PyScriptTest):
"hello asciitree", # printed by us
]
@skip_worker("FIXME: the banner doesn't appear")
@pytest.mark.skip("FIXME: No banner")
def test_non_existent_package(self):
self.pyscript_run(
"""
@@ -198,7 +207,7 @@ class TestBasic(PyScriptTest):
assert expected_alert_banner_msg in alert_banner.inner_text()
self.check_py_errors("Can't fetch metadata for 'i-dont-exist'")
@skip_worker("FIXME: the banner doesn't appear")
@pytest.mark.skip("FIXME: No banner")
def test_no_python_wheel(self):
self.pyscript_run(
"""
@@ -218,18 +227,20 @@ class TestBasic(PyScriptTest):
assert expected_alert_banner_msg in alert_banner.inner_text()
self.check_py_errors("Can't find a pure Python 3 wheel for 'opsdroid'")
@pytest.mark.skip("""FIXME: Dynamically adding a py-script tag fails""")
def test_dynamically_add_py_script_tag(self):
self.pyscript_run(
"""
<script>
function addPyScriptTag() {
function addPyScriptTag(event) {
let tag = document.createElement('py-script');
tag.innerHTML = "print('hello world')";
document.body.appendChild(tag);
}
</script>
<button onclick="addPyScriptTag()">Click me</button>
"""
""",
timeout=20000,
)
self.page.locator("button").click()
@@ -245,6 +256,7 @@ class TestBasic(PyScriptTest):
)
assert self.console.log.lines[-1] == "hello from foo"
@pytest.mark.skip("FIXME: No banner")
def test_py_script_src_not_found(self):
self.pyscript_run(
"""
@@ -263,6 +275,7 @@ class TestBasic(PyScriptTest):
self.check_js_errors(expected_msg)
@pytest.mark.skip("DIFFERENT BEHAVIOUR?: we don't expose pyscript on window")
def test_js_version(self):
self.pyscript_run(
"""
@@ -277,6 +290,7 @@ class TestBasic(PyScriptTest):
is not None
)
@pytest.mark.skip("DIFFERENT BEHAVIOUR?: we don't expose pyscript on window")
def test_python_version(self):
self.pyscript_run(
"""
@@ -300,7 +314,7 @@ class TestBasic(PyScriptTest):
is not None
)
@skip_worker("FIXME: showWarning()")
@pytest.mark.skip("FIXME: No banner")
def test_assert_no_banners(self):
"""
Test that the DOM doesn't contain error/warning banners
@@ -314,31 +328,29 @@ class TestBasic(PyScriptTest):
</py-script>
"""
)
# check that we have 2 banners
with pytest.raises(AssertionError, match="Found 2 alert banners"):
self.assert_no_banners()
def test_getPySrc_returns_source_code(self):
self.pyscript_run(
"""
<py-script>
print("hello world!")
</py-script>
<py-script>print("hello world!")</py-script>
"""
)
pyscript_tag = self.page.locator("py-script")
assert pyscript_tag.inner_html() == ""
assert (
pyscript_tag.evaluate("node => node.getPySrc()")
== 'print("hello world!")\n'
)
assert pyscript_tag.evaluate("node => node.srcCode") == 'print("hello world!")'
@pytest.mark.skip(reason="FIX TEST: works in chrome!")
def test_py_attribute_without_id(self):
self.pyscript_run(
"""
<button py-click="myfunc()">Click me</button>
<button py-click="myfunc">Click me</button>
<py-script>
def myfunc():
def myfunc(event):
print("hello world!")
</py-script>
"""
@@ -349,6 +361,8 @@ class TestBasic(PyScriptTest):
assert self.console.log.lines[-1] == "hello world!"
assert self.console.error.lines == []
# TODO: THis can actually be removed since we are removing `py-mount`
@pytest.mark.skip("REMOVE TEST: No py-mount anymore")
def test_py_mount_shows_deprecation_warning(self):
# last non-deprecated version: 2023.03.1
self.pyscript_run(