jprdonnelly/pyscript
1
0
Fork 0
mirror of https://github.com/pyscript/pyscript.git synced 2025-12-21 03:05:38 -05:00
Code Issues Projects Releases Wiki Activity

Remove all but 2 eslint-disable pragmas (#1335)

Browse Source 
Turns off:
 - no-explicit-any (we need to handle any return values from runPython)
 - no-unsafe-assignment (noisy and pointless)

And resolves all but two remaining ones. The last two lints regard access to private Pyodide variables and so:
 - they are not easy to work around without an upstream Pyodide patch
 - they should trigger linter and require explicit override
This commit is contained in:
Hood Chatham
2023-03-30 10:51:36 -07:00
committed by GitHub
parent 854e9d1378
commit 146afb6532
13 changed files with 42 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
pyscriptjs/src/plugin.ts
View File

@@ -1,8 +1,4 @@
/* eslint-disable @typescript-eslint/no-unsafe-member-access,
@typescript-eslint/no-unsafe-call,
@typescript-eslint/no-explicit-any,
@typescript-eslint/no-unsafe-assignment */
import type { PyScriptApp } from './main';
import type { AppConfig } from './pyconfig';
import type { UserError } from './exceptions';
import { getLogger } from './logger';
@@ -125,9 +121,21 @@ export class Plugin {
}
}
export type PythonPlugin = {
init(app: PyScriptApp): void;
configure?: (config: AppConfig) => Promise<void>;
afterSetup?: (interpreter: InterpreterClient) => Promise<void>;
afterStartup?: (interpreter: InterpreterClient) => Promise<void>;
beforePyScriptExec?: { callKwargs: (options: any) => Promise<void> };
afterPyScriptExec?: { callKwargs: (options: any) => Promise<void> };
beforePyReplExec?: { callKwargs: (options: any) => Promise<void> };
afterPyReplExec?: { callKwargs: (options: any) => Promise<void> };
onUserError?: (error: UserError) => Promise<void>;
};
export class PluginManager {
_plugins: Plugin[];
_pythonPlugins: any[];
_pythonPlugins: PythonPlugin[];
constructor() {
this._plugins = [];
@@ -138,7 +146,7 @@ export class PluginManager {
for (const p of plugins) this._plugins.push(p);
}
addPythonPlugin(plugin: any) {
addPythonPlugin(plugin: PythonPlugin) {
this._pythonPlugins.push(plugin);
}
@@ -179,8 +187,7 @@ export class PluginManager {
async beforePyScriptExec(options: { interpreter: InterpreterClient; src: string; pyScriptTag: PyScriptTag }) {
for (const p of this._plugins) p.beforePyScriptExec?.(options);
for (const p of this._pythonPlugins)
await p.beforePyScriptExec(options.interpreter, options.src, options.pyScriptTag);
for (const p of this._pythonPlugins) await p.beforePyScriptExec.callKwargs(options);
}
async afterPyScriptExec(options: {
@@ -191,8 +198,7 @@ export class PluginManager {
}) {
for (const p of this._plugins) p.afterPyScriptExec?.(options);
for (const p of this._pythonPlugins)
await p.afterPyScriptExec(options.interpreter, options.src, options.pyScriptTag, options.result);
for (const p of this._pythonPlugins) await p.afterPyScriptExec.callKwargs(options);
}
async beforePyReplExec(options: {
@@ -203,21 +209,13 @@ export class PluginManager {
}) {
for (const p of this._plugins) p.beforePyReplExec?.(options);
for (const p of this._pythonPlugins)
await p.beforePyReplExec?.(options.interpreter, options.src, options.outEl, options.pyReplTag);
for (const p of this._pythonPlugins) await p.beforePyReplExec?.callKwargs(options);
}
async afterPyReplExec(options: { interpreter: InterpreterClient; src: string; outEl; pyReplTag; result }) {
for (const p of this._plugins) p.afterPyReplExec?.(options);
for (const p of this._pythonPlugins)
await p.afterPyReplExec?.(
options.interpreter,
options.src,
options.outEl,
options.pyReplTag,
options.result,
);
for (const p of this._pythonPlugins) await p.afterPyReplExec?.callKwargs(options);
}
async onUserError(error: UserError) {
@@ -227,6 +225,9 @@ export class PluginManager {
}
}
type PyElementInstance = { connect(): void };
type PyElementClass = (htmlElement: HTMLElement) => PyElementInstance;
/**
* Defines a new CustomElement (via customElement.defines) with `tag`,
* where the new CustomElement is a proxy that delegates the logic to
@@ -238,12 +239,12 @@ export class PluginManager {
* received by the newly created CustomElement will be
* delegated to that instance.
*/
export function define_custom_element(tag: string, pyPluginClass: any): any {
export function define_custom_element(tag: string, pyElementClass: PyElementClass): any {
logger.info(`creating plugin: ${tag}`);
class ProxyCustomElement extends HTMLElement {
shadow: ShadowRoot;
wrapper: HTMLElement;
pyPluginInstance: any;
pyElementInstance: PyElementInstance;
originalInnerHTML: string;
constructor() {
@@ -254,11 +255,11 @@ export function define_custom_element(tag: string, pyPluginClass: any): any {
this.wrapper = document.createElement('slot');
this.shadow.appendChild(this.wrapper);
this.originalInnerHTML = this.innerHTML;
this.pyPluginInstance = pyPluginClass(this);
this.pyElementInstance = pyElementClass(this);
}
connectedCallback() {
const innerHTML = this.pyPluginInstance.connect();
const innerHTML = this.pyElementInstance.connect();
if (typeof innerHTML === 'string') this.innerHTML = innerHTML;
}
}