mirror of
https://github.com/pyscript/pyscript.git
synced 2025-12-22 19:53:00 -05:00
Enable worker tests (#1757)
This PR re-enables tests on `worker`s. Highlights: * by default, each test is run twice: the main thread version uses `<script type="py">`, the worker version automatically turn the tags into `<script type="py" worker>` * you can tweak the settings per-class by using the `@with_execution_thread` decorator. In particular, `@with_execution_thread(None)` is for those tests which don't care about it (e.g., `test_py_config.py`) * inside each class, there might be some test which should be run only in the main thread (because it doesn't make sense to test it in a worker). For those, I introduced the `@only_main` decorator * we might introduce `@only_worker` in the future, if needed * `@skip_worker` is for those tests which currently pass on main but not on workers. These are meant to be temporary, and eventually they should all be fixed During the process, I tweaked/improved/fixed/deleted some of the existing tests. Some of them were at risk of being flaky and I made them more robust, others depended on some very precise implementation detail, and I made them more generic (for example, `test_image_renders_correctly` relied on pillow to render an image with a very specific string of bytes, and it broke due to the recent upgrade to pyodide 0.24.1) I also renamed all the skip messages to start with `NEXT`, so that they are easier to grep.
This commit is contained in:
Antonio Cuni
178
pyscript.core/tests/integration/test_when.py
Normal file
178
pyscript.core/tests/integration/test_when.py
Normal file
@@ -0,0 +1,178 @@
|
||||
import pytest
|
||||
|
||||
from .support import PyScriptTest, skip_worker
|
||||
|
||||
|
||||
class TestEventHandler(PyScriptTest):
|
||||
def test_when_decorator_with_event(self):
|
||||
"""When the decorated function takes a single parameter,
|
||||
it should be passed the event object
|
||||
"""
|
||||
self.pyscript_run(
|
||||
"""
|
||||
<button id="foo_id">foo_button</button>
|
||||
<script type="py">
|
||||
from pyscript import when
|
||||
@when("click", selector="#foo_id")
|
||||
def foo(evt):
|
||||
print(f"clicked {evt.target.id}")
|
||||
</script>
|
||||
"""
|
||||
)
|
||||
self.page.locator("text=foo_button").click()
|
||||
self.wait_for_console("clicked foo_id")
|
||||
self.assert_no_banners()
|
||||
|
||||
def test_when_decorator_without_event(self):
|
||||
"""When the decorated function takes no parameters (not including 'self'),
|
||||
it should be called without the event object
|
||||
"""
|
||||
self.pyscript_run(
|
||||
"""
|
||||
<button id="foo_id">foo_button</button>
|
||||
<script type="py">
|
||||
from pyscript import when
|
||||
@when("click", selector="#foo_id")
|
||||
def foo():
|
||||
print("The button was clicked")
|
||||
</script>
|
||||
"""
|
||||
)
|
||||
self.page.locator("text=foo_button").click()
|
||||
self.wait_for_console("The button was clicked")
|
||||
self.assert_no_banners()
|
||||
|
||||
def test_multiple_when_decorators_with_event(self):
|
||||
self.pyscript_run(
|
||||
"""
|
||||
<button id="foo_id">foo_button</button>
|
||||
<button id="bar_id">bar_button</button>
|
||||
<script type="py">
|
||||
from pyscript import when
|
||||
@when("click", selector="#foo_id")
|
||||
def foo_click(evt):
|
||||
print(f"foo_click! id={evt.target.id}")
|
||||
@when("click", selector="#bar_id")
|
||||
def bar_click(evt):
|
||||
print(f"bar_click! id={evt.target.id}")
|
||||
</script>
|
||||
"""
|
||||
)
|
||||
self.page.locator("text=foo_button").click()
|
||||
self.wait_for_console("foo_click! id=foo_id")
|
||||
self.page.locator("text=bar_button").click()
|
||||
self.wait_for_console("bar_click! id=bar_id")
|
||||
self.assert_no_banners()
|
||||
|
||||
def test_two_when_decorators(self):
|
||||
"""When decorating a function twice, both should function"""
|
||||
self.pyscript_run(
|
||||
"""
|
||||
<button id="foo_id">foo_button</button>
|
||||
<button class="bar_class">bar_button</button>
|
||||
<script type="py">
|
||||
from pyscript import when
|
||||
@when("click", selector="#foo_id")
|
||||
@when("mouseover", selector=".bar_class")
|
||||
def foo(evt):
|
||||
print(f"got event: {evt.type}")
|
||||
</script>
|
||||
"""
|
||||
)
|
||||
self.page.locator("text=bar_button").hover()
|
||||
self.wait_for_console("got event: mouseover")
|
||||
self.page.locator("text=foo_button").click()
|
||||
self.wait_for_console("got event: click")
|
||||
self.assert_no_banners()
|
||||
|
||||
def test_two_when_decorators_same_element(self):
|
||||
"""When decorating a function twice *on the same DOM element*, both should function"""
|
||||
self.pyscript_run(
|
||||
"""
|
||||
<button id="foo_id">foo_button</button>
|
||||
<script type="py">
|
||||
from pyscript import when
|
||||
@when("click", selector="#foo_id")
|
||||
@when("mouseover", selector="#foo_id")
|
||||
def foo(evt):
|
||||
print(f"got event: {evt.type}")
|
||||
</script>
|
||||
"""
|
||||
)
|
||||
self.page.locator("text=foo_button").hover()
|
||||
self.wait_for_console("got event: mouseover")
|
||||
self.page.locator("text=foo_button").click()
|
||||
self.wait_for_console("got event: click")
|
||||
self.assert_no_banners()
|
||||
|
||||
def test_when_decorator_multiple_elements(self):
|
||||
"""The @when decorator's selector should successfully select multiple
|
||||
DOM elements
|
||||
"""
|
||||
self.pyscript_run(
|
||||
"""
|
||||
<button class="bar_class">button1</button>
|
||||
<button class="bar_class">button2</button>
|
||||
<script type="py">
|
||||
from pyscript import when
|
||||
@when("click", selector=".bar_class")
|
||||
def foo(evt):
|
||||
print(f"{evt.target.innerText} was clicked")
|
||||
</script>
|
||||
"""
|
||||
)
|
||||
self.page.locator("text=button1").click()
|
||||
self.page.locator("text=button2").click()
|
||||
self.wait_for_console("button2 was clicked")
|
||||
assert "button1 was clicked" in self.console.log.lines
|
||||
assert "button2 was clicked" in self.console.log.lines
|
||||
self.assert_no_banners()
|
||||
|
||||
def test_when_decorator_duplicate_selectors(self):
|
||||
""" """
|
||||
self.pyscript_run(
|
||||
"""
|
||||
<button id="foo_id">foo_button</button>
|
||||
<script type="py">
|
||||
from pyscript import when
|
||||
@when("click", selector="#foo_id")
|
||||
@when("click", selector="#foo_id")
|
||||
def foo(evt):
|
||||
foo.n += 1
|
||||
print(f"click {foo.n} on {evt.target.id}")
|
||||
foo.n = 0
|
||||
</script>
|
||||
"""
|
||||
)
|
||||
self.page.locator("text=foo_button").click()
|
||||
self.wait_for_console("click 1 on foo_id")
|
||||
self.wait_for_console("click 2 on foo_id")
|
||||
self.assert_no_banners()
|
||||
|
||||
@skip_worker("NEXT: error banner not shown")
|
||||
def test_when_decorator_invalid_selector(self):
|
||||
"""When the selector parameter of @when is invalid, it should show an error"""
|
||||
self.pyscript_run(
|
||||
"""
|
||||
<button id="foo_id">foo_button</button>
|
||||
<script type="py">
|
||||
from pyscript import when
|
||||
@when("click", selector="#.bad")
|
||||
def foo(evt):
|
||||
...
|
||||
</script>
|
||||
"""
|
||||
)
|
||||
self.page.locator("text=foo_button").click()
|
||||
msg = "Failed to execute 'querySelectorAll' on 'Document': '#.bad' is not a valid selector."
|
||||
error = self.page.wait_for_selector(".py-error")
|
||||
banner_text = error.inner_text()
|
||||
|
||||
if msg not in banner_text:
|
||||
raise AssertionError(
|
||||
f"Expected message '{msg}' does not "
|
||||
f"match banner text '{banner_text}'"
|
||||
)
|
||||
|
||||
assert msg in self.console.error.lines[-1]
|
||||
self.check_py_errors(msg)
|
||||
Reference in New Issue
Block a user