From bccd5e3750e9009723be882d82a4afc60be6415d Mon Sep 17 00:00:00 2001
From: Andrea Giammarchi <andrea.giammarchi@gmail.com>
Date: Fri, 16 Jun 2023 15:34:05 +0200
Subject: [PATCH] Fix #1538 - use same customElements Registry utilities
 (#1542)

---
 .pre-commit-config.yaml                       |   3 +-
 .../esm/{plugins.js => custom-types.js}       | 105 +++++++++++++-----
 pyscript.core/esm/index.js                    |  87 +++------------
 pyscript.core/esm/listeners.js                |  71 ++++++++++++
 pyscript.core/esm/worker/class.js             |   2 +-
 pyscript.core/test/plugins/index.html         |  21 +++-
 pyscript.core/test/plugins/lua.html           |  12 +-
 pyscript.core/test/plugins/py-script.js       |   6 +-
 8 files changed, 194 insertions(+), 113 deletions(-)
 rename pyscript.core/esm/{plugins.js => custom-types.js} (63%)
 create mode 100644 pyscript.core/esm/listeners.js

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 14e99e2a..1abc5212 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -14,7 +14,7 @@ repos:
           - id: check-docstring-first
           - id: check-executables-have-shebangs
           - id: check-json
-            exclude: tsconfig.json pyscript.core/cjs/package.json
+            exclude: tsconfig\.json|pyscript\.core/cjs/package\.json
           - id: check-toml
           - id: check-xml
           - id: check-yaml
@@ -46,6 +46,7 @@ repos:
       rev: "v3.0.0-alpha.6"
       hooks:
           - id: prettier
+            exclude: pyscript\.core/test
             args: [--tab-width, "4"]
 
     - repo: https://github.com/pre-commit/mirrors-eslint
diff --git a/pyscript.core/esm/plugins.js b/pyscript.core/esm/custom-types.js
similarity index 63%
rename from pyscript.core/esm/plugins.js
rename to pyscript.core/esm/custom-types.js
index d51366e1..854882bb 100644
--- a/pyscript.core/esm/plugins.js
+++ b/pyscript.core/esm/custom-types.js
@@ -1,18 +1,23 @@
+import "@ungap/with-resolvers";
 import { $$ } from "basic-devtools";
 
-import { create } from "./utils.js";
+import { assign, create } from "./utils.js";
 import { getDetails } from "./script-handler.js";
-import { registry, configs } from "./interpreters.js";
+import {
+    registry as defaultRegistry,
+    prefixes,
+    configs,
+} from "./interpreters.js";
 import { getRuntimeID } from "./loader.js";
 import { io } from "./interpreter/_utils.js";
+import { addAllListeners } from "./listeners.js";
 
 import workerHooks from "./worker/hooks.js";
 
-export const PLUGINS_SELECTORS = [];
+export const CUSTOM_SELECTORS = [];
 
 /**
- * @typedef {Object} Runtime plugin configuration
- * @prop {string} type the interpreter type
+ * @typedef {Object} Runtime custom configuration
  * @prop {object} interpreter the bootstrapped interpreter
  * @prop {(url:string, options?: object) => Worker} XWorker an XWorker constructor that defaults to same interpreter on the Worker.
  * @prop {object} config a cloned config used to bootstrap the interpreter
@@ -22,23 +27,33 @@ export const PLUGINS_SELECTORS = [];
  */
 
 const patched = new Map();
+const types = new Map();
+const waitList = new Map();
 
 // REQUIRES INTEGRATION TEST
 /* c8 ignore start */
 /**
- * @param {Element} node any DOM element registered via plugin.
+ * @param {Element} node any DOM element registered via define.
  */
-export const handlePlugin = (node) => {
-    for (const name of PLUGINS_SELECTORS) {
-        if (node.matches(name)) {
-            const { options, known } = plugins.get(name);
+export const handleCustomType = (node) => {
+    for (const selector of CUSTOM_SELECTORS) {
+        if (node.matches(selector)) {
+            const type = types.get(selector);
+            const { resolve } = waitList.get(type);
+            const { options, known } = registry.get(type);
             if (!known.has(node)) {
                 known.add(node);
-                const { type, version, config, env, onRuntimeReady } = options;
-                const name = getRuntimeID(type, version);
+                const {
+                    interpreter: runtime,
+                    version,
+                    config,
+                    env,
+                    onRuntimeReady,
+                } = options;
+                const name = getRuntimeID(runtime, version);
                 const id = env || `${name}${config ? `|${config}` : ""}`;
                 const { interpreter: engine, XWorker } = getDetails(
-                    type,
+                    runtime,
                     id,
                     name,
                     version,
@@ -46,7 +61,7 @@ export const handlePlugin = (node) => {
                 );
                 engine.then((interpreter) => {
                     if (!patched.has(id)) {
-                        const module = create(registry.get(type));
+                        const module = create(defaultRegistry.get(runtime));
                         const {
                             onBeforeRun,
                             onBeforeRunAsync,
@@ -120,9 +135,10 @@ export const handlePlugin = (node) => {
                         };
 
                         patched.set(id, resolved);
+                        resolve(resolved);
                     }
 
-                    onRuntimeReady(patched.get(id), node);
+                    onRuntimeReady?.(patched.get(id), node);
                 });
             }
         }
@@ -132,27 +148,58 @@ export const handlePlugin = (node) => {
 /**
  * @type {Map<string, {options:object, known:WeakSet<Element>}>}
  */
-const plugins = new Map();
+const registry = new Map();
 
 /**
- * @typedef {Object} PluginOptions plugin configuration
- * @prop {string} type the interpreter/interpreter type to receive
+ * @typedef {Object} PluginOptions custom configuration
+ * @prop {'pyodide' | 'micropython' | 'wasmoon' | 'ruby-wasm-wasi'} interpreter the interpreter to use
  * @prop {string} [version] the optional interpreter version to use
  * @prop {string} [config] the optional config to use within such interpreter
- * @prop {string} [env] the optional environment to use
- * @prop {(node: Element, interpreter: Runtime) => void} onRuntimeReady the callback that will be invoked once
+ * @prop {(environment: object, node: Element) => void} [onRuntimeReady] the callback that will be invoked once
  */
 
 /**
- * Allows plugins and components on the page to receive interpreters to execute any code.
- * @param {string} name the unique plugin name
- * @param {PluginOptions} options the plugin configuration
+ * Allows custom types and components on the page to receive interpreters to execute any code
+ * @param {string} type the unique `<script type="...">` identifier
+ * @param {PluginOptions} options the custom type configuration
  */
-export const registerPlugin = (name, options) => {
-    if (PLUGINS_SELECTORS.includes(name))
-        throw new Error(`plugin ${name} already registered`);
-    PLUGINS_SELECTORS.push(name);
-    plugins.set(name, { options, known: new WeakSet() });
-    $$(name).forEach(handlePlugin);
+export const define = (type, options) => {
+    if (defaultRegistry.has(type) || registry.has(type))
+        throw new Error(`<script type="${type}"> already registered`);
+
+    if (!defaultRegistry.has(options?.interpreter))
+        throw new Error(`Unspecified interpreter`);
+
+    // allows reaching out the interpreter helpers on events
+    defaultRegistry.set(type, defaultRegistry.get(options?.interpreter));
+
+    // ensure a Promise can resolve once a custom type has been bootstrapped
+    whenDefined(type);
+
+    // allows selector -> registry by type
+    const selectors = [`script[type="${type}"]`, `${type}-script`];
+    for (const selector of selectors) types.set(selector, type);
+
+    CUSTOM_SELECTORS.push(...selectors);
+    prefixes.push(`${type}-`);
+
+    // ensure always same env for this custom type
+    registry.set(type, {
+        options: assign({ env: type }, options),
+        known: new WeakSet(),
+    });
+
+    addAllListeners(document);
+    $$(selectors.join(",")).forEach(handleCustomType);
+};
+
+/**
+ * Resolves whenever a defined custom type is bootstrapped on the page
+ * @param {string} type the unique `<script type="...">` identifier
+ * @returns {Promise<object>}
+ */
+export const whenDefined = (type) => {
+    if (!waitList.has(type)) waitList.set(type, Promise.withResolvers());
+    return waitList.get(type).promise;
 };
 /* c8 ignore stop */
diff --git a/pyscript.core/esm/index.js b/pyscript.core/esm/index.js
index 2db37784..9951d636 100644
--- a/pyscript.core/esm/index.js
+++ b/pyscript.core/esm/index.js
@@ -1,71 +1,16 @@
-import { $x, $$ } from "basic-devtools";
+import { $$ } from "basic-devtools";
 
 import xworker from "./worker/class.js";
-import { handle, interpreters } from "./script-handler.js";
-import { all, assign, create, defineProperty } from "./utils.js";
-import { registry, selectors, prefixes } from "./interpreters.js";
-import { PLUGINS_SELECTORS, handlePlugin } from "./plugins.js";
+import { handle } from "./script-handler.js";
+import { assign } from "./utils.js";
+import { selectors, prefixes } from "./interpreters.js";
+import { CUSTOM_SELECTORS, handleCustomType } from "./custom-types.js";
+import { listener, addAllListeners } from "./listeners.js";
 
-export { registerPlugin } from "./plugins.js";
+export { define, whenDefined } from "./custom-types.js";
 export const XWorker = xworker();
 
-const RUNTIME_SELECTOR = selectors.join(",");
-
-// ensure both interpreter and its queue are awaited then returns the interpreter
-const awaitRuntime = async (key) => {
-    if (interpreters.has(key)) {
-        const { interpreter, queue } = interpreters.get(key);
-        return (await all([interpreter, queue]))[0];
-    }
-
-    const available = interpreters.size
-        ? `Available interpreters are: ${[...interpreters.keys()]
-              .map((r) => `"${r}"`)
-              .join(", ")}.`
-        : `There are no interpreters in this page.`;
-
-    throw new Error(`The interpreter "${key}" was not found. ${available}`);
-};
-
-defineProperty(globalThis, "pyscript", {
-    value: {
-        env: new Proxy(create(null), { get: (_, name) => awaitRuntime(name) }),
-    },
-});
-
-let index = 0;
-globalThis.__events = new Map();
-
-// attributes are tested via integration / e2e
-/* c8 ignore next 17 */
-const listener = async (event) => {
-    const { type, currentTarget } = event;
-    for (let { name, value, ownerElement: el } of $x(
-        `./@*[${prefixes.map((p) => `name()="${p}${type}"`).join(" or ")}]`,
-        currentTarget,
-    )) {
-        name = name.slice(0, -(type.length + 1));
-        const interpreter = await awaitRuntime(
-            el.getAttribute(`${name}-env`) || name,
-        );
-        const i = index++;
-        try {
-            globalThis.__events.set(i, event);
-            registry.get(name).runEvent(interpreter, value, i);
-        } finally {
-            globalThis.__events.delete(i);
-        }
-    }
-};
-
-// attributes are tested via integration / e2e
-/* c8 ignore next 8 */
-for (let { name, ownerElement: el } of $x(
-    `.//@*[${prefixes.map((p) => `starts-with(name(),"${p}")`).join(" or ")}]`,
-)) {
-    name = name.slice(name.lastIndexOf("-") + 1);
-    if (name !== "env") el.addEventListener(name, listener);
-}
+const INTERPRETER_SELECTORS = selectors.join(",");
 
 const mo = new MutationObserver((records) => {
     for (const { type, target, attributeName, addedNodes } of records) {
@@ -92,12 +37,15 @@ const mo = new MutationObserver((records) => {
         }
         for (const node of addedNodes) {
             if (node.nodeType === 1) {
-                if (node.matches(RUNTIME_SELECTOR)) handle(node);
+                addAllListeners(node);
+                if (node.matches(INTERPRETER_SELECTORS)) handle(node);
                 else {
-                    $$(RUNTIME_SELECTOR, node).forEach(handle);
-                    if (!PLUGINS_SELECTORS.length) continue;
-                    handlePlugin(node);
-                    $$(PLUGINS_SELECTORS.join(","), node).forEach(handlePlugin);
+                    $$(INTERPRETER_SELECTORS, node).forEach(handle);
+                    if (!CUSTOM_SELECTORS.length) continue;
+                    handleCustomType(node);
+                    $$(CUSTOM_SELECTORS.join(","), node).forEach(
+                        handleCustomType,
+                    );
                 }
             }
         }
@@ -116,4 +64,5 @@ assign(Element.prototype, {
     },
 });
 
-$$(RUNTIME_SELECTOR, observe(document)).forEach(handle);
+addAllListeners(observe(document));
+$$(INTERPRETER_SELECTORS, document).forEach(handle);
diff --git a/pyscript.core/esm/listeners.js b/pyscript.core/esm/listeners.js
new file mode 100644
index 00000000..71c433e7
--- /dev/null
+++ b/pyscript.core/esm/listeners.js
@@ -0,0 +1,71 @@
+import { $x } from "basic-devtools";
+
+import { interpreters } from "./script-handler.js";
+import { all, create, defineProperty } from "./utils.js";
+import { registry, prefixes } from "./interpreters.js";
+
+// TODO: this is ugly; need to find a better way
+defineProperty(globalThis, "pyscript", {
+    value: {
+        env: new Proxy(create(null), {
+            get: (_, name) => awaitInterpreter(name),
+        }),
+    },
+});
+
+let index = 0;
+globalThis.__events = new Map();
+
+/* c8 ignore start */ // attributes are tested via integration / e2e
+// ensure both interpreter and its queue are awaited then returns the interpreter
+const awaitInterpreter = async (key) => {
+    if (interpreters.has(key)) {
+        const { interpreter, queue } = interpreters.get(key);
+        return (await all([interpreter, queue]))[0];
+    }
+
+    const available = interpreters.size
+        ? `Available interpreters are: ${[...interpreters.keys()]
+              .map((r) => `"${r}"`)
+              .join(", ")}.`
+        : `There are no interpreters in this page.`;
+
+    throw new Error(`The interpreter "${key}" was not found. ${available}`);
+};
+
+export const listener = async (event) => {
+    const { type, currentTarget } = event;
+    for (let { name, value, ownerElement: el } of $x(
+        `./@*[${prefixes.map((p) => `name()="${p}${type}"`).join(" or ")}]`,
+        currentTarget,
+    )) {
+        name = name.slice(0, -(type.length + 1));
+        const interpreter = await awaitInterpreter(
+            el.getAttribute(`${name}-env`) || name,
+        );
+        const i = index++;
+        try {
+            globalThis.__events.set(i, event);
+            registry.get(name).runEvent(interpreter, value, i);
+        } finally {
+            globalThis.__events.delete(i);
+        }
+    }
+};
+
+/**
+ * Look for known prefixes and add related listeners.
+ * @param {Document | Element} root
+ */
+export const addAllListeners = (root) => {
+    for (let { name, ownerElement: el } of $x(
+        `.//@*[${prefixes
+            .map((p) => `starts-with(name(),"${p}")`)
+            .join(" or ")}]`,
+        root,
+    )) {
+        name = name.slice(name.lastIndexOf("-") + 1);
+        if (name !== "env") el.addEventListener(name, listener);
+    }
+};
+/* c8 ignore stop */
diff --git a/pyscript.core/esm/worker/class.js b/pyscript.core/esm/worker/class.js
index 720a8742..742dccef 100644
--- a/pyscript.core/esm/worker/class.js
+++ b/pyscript.core/esm/worker/class.js
@@ -5,7 +5,7 @@ import { getText } from "../fetch-utils.js";
 import workerHooks from "./hooks.js";
 
 /**
- * @typedef {Object} WorkerOptions plugin configuration
+ * @typedef {Object} WorkerOptions custom configuration
  * @prop {string} type the interpreter type to use
  * @prop {string} [version] the optional interpreter version to use
  * @prop {string} [config] the optional config to use within such interpreter
diff --git a/pyscript.core/test/plugins/index.html b/pyscript.core/test/plugins/index.html
index dc047de5..4a23d509 100644
--- a/pyscript.core/test/plugins/index.html
+++ b/pyscript.core/test/plugins/index.html
@@ -5,7 +5,7 @@
         <meta name="viewport" content="width=device-width,initial-scale=1.0" />
         <title>Plugins</title>
         <style>
-            py-script {
+            mpy-script {
                 display: none;
             }
         </style>
@@ -13,9 +13,10 @@
             { "imports": { "@pyscript/core": "../../min.js" } }
         </script>
         <script type="module">
-            import { registerPlugin } from "@pyscript/core";
-            registerPlugin("mpy-script", {
-                type: "micropython",
+            import { define, whenDefined } from "@pyscript/core";
+            whenDefined("mpy").then(console.log);
+            define("mpy", {
+                interpreter: "micropython",
                 async onRuntimeReady(micropython, element) {
                     console.log(micropython);
                     // Somehow this doesn't work in MicroPython
@@ -25,11 +26,21 @@
                     micropython.run(element.textContent);
                     element.replaceChildren("See console ->");
                     element.style.display = "block";
+
+                    const button = document.createElement("button");
+                    button.textContent = "click";
+                    button.setAttribute("mpy-click", "test_click(event)");
+                    document.body.append(button);
                 },
             });
         </script>
     </head>
     <body>
-        <mpy-script> print('Hello Console!') </mpy-script>
+        <mpy-script mpy-click="test_click(event)">
+            def test_click(event):
+                print(event.type)
+
+            print('Hello Console!')
+        </mpy-script>
     </body>
 </html>
diff --git a/pyscript.core/test/plugins/lua.html b/pyscript.core/test/plugins/lua.html
index 32a154b6..921dc3f5 100644
--- a/pyscript.core/test/plugins/lua.html
+++ b/pyscript.core/test/plugins/lua.html
@@ -5,7 +5,7 @@
         <meta name="viewport" content="width=device-width,initial-scale=1.0" />
         <title>Plugins</title>
         <style>
-            py-script {
+            lua-script {
                 display: none;
             }
         </style>
@@ -13,9 +13,9 @@
             { "imports": { "@pyscript/core": "../../min.js" } }
         </script>
         <script type="module">
-            import { registerPlugin } from "@pyscript/core";
-            registerPlugin("lua-script", {
-                type: "wasmoon",
+            import { define } from "@pyscript/core";
+            define("lua", {
+                interpreter: "wasmoon",
                 async onRuntimeReady(wasmoon, element) {
                     // Somehow this doesn't work in Wasmoon
                     wasmoon.io.stdout = (message) => {
@@ -29,6 +29,8 @@
         </script>
     </head>
     <body>
-        <lua-script> print('Hello Console!') </lua-script>
+        <lua-script lua-click="print(event.type)">
+            print('Hello Console!')
+        </lua-script>
     </body>
 </html>
diff --git a/pyscript.core/test/plugins/py-script.js b/pyscript.core/test/plugins/py-script.js
index 35f0657b..8b05d7b2 100644
--- a/pyscript.core/test/plugins/py-script.js
+++ b/pyscript.core/test/plugins/py-script.js
@@ -1,4 +1,4 @@
-import { registerPlugin } from "@pyscript/core";
+import { define } from "@pyscript/core";
 
 // append ASAP CSS to avoid showing content
 document.head.appendChild(document.createElement("style")).textContent = `
@@ -17,9 +17,9 @@ let bootstrap = true,
 const sharedPyodide = new Promise((resolve) => {
     const pyConfig = document.querySelector("py-config");
     const config = pyConfig?.getAttribute("src") || pyConfig?.textContent;
-    registerPlugin("py-script", {
+    define("py", {
         config,
-        type: "pyodide",
+        interpreter: "pyodide",
         codeBeforeRunWorker: `print('codeBeforeRunWorker')`,
         codeAfterRunWorker: `print('codeAfterRunWorker')`,
         onBeforeRun(pyodide, node) {