jprdonnelly/redash
1
0
Fork 0
mirror of https://github.com/getredash/redash.git synced 2025-12-25 01:03:20 -05:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2514 from atharvai/gsheets_parse_fix_2504

Browse Source 
Update value parsing for google spreadsheets source
This commit is contained in:
Arik Fraimovich
2018-07-19 12:02:36 +03:00
committed by GitHub
parent 35bb558f44 48acc4c7a7
commit 25de0b9dab
3 changed files with 20 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/query_runner/test_google_spreadsheets.py
View File

@@ -38,12 +38,12 @@ class TestGuessType(TestCase):
class TestValueEvalList(TestCase):
def test_handles_unicode(self):
values = [u'יוניקוד', 'test', 'value']
self.assertEqual(values, _value_eval_list(values))
self.assertEqual(values, _value_eval_list(values, [TYPE_STRING]*len(values)))
def test_handles_boolean(self):
values = ['true', 'false', 'True', 'False', 'TRUE', 'FALSE']
converted_values = [True, False, True, False, True, False]
self.assertEqual(converted_values, _value_eval_list(values))
self.assertEqual(converted_values, _value_eval_list(values, [TYPE_BOOLEAN]*len(values)))
def test_handles_empty_values(self):
values = ['', None]