From 4ecc8da398f7efcb2a570209d50c854297a35da5 Mon Sep 17 00:00:00 2001
From: Tyler Rockwood <rockwood@google.com>
Date: Mon, 15 May 2017 13:51:01 -0700
Subject: [PATCH] Addressing comments

---
 client/app/components/parameter-settings.html | 2 +-
 client/app/components/parameters.html         | 2 +-
 client/app/components/parameters.js           | 6 +++++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/client/app/components/parameter-settings.html b/client/app/components/parameter-settings.html
index 12f79975a..d006c5fef 100644
--- a/client/app/components/parameter-settings.html
+++ b/client/app/components/parameter-settings.html
@@ -23,7 +23,7 @@
         <label>Global</label>
         <input type="checkbox" class="form-inline" ng-model="$ctrl.parameter.global">
       </div>
-      <div class="form-group">
+      <div class="form-group" ng-if="$ctrl.parameter.type === 'enum'">
         <label>Values (newline delimited)</label>
         <textarea class="form-control" rows="3" ng-model="$ctl.parameter.enumOptions">
       </div>
diff --git a/client/app/components/parameters.html b/client/app/components/parameters.html
index 361d626dd..b1b33f4d3 100644
--- a/client/app/components/parameters.html
+++ b/client/app/components/parameters.html
@@ -8,7 +8,7 @@
       <input ng-switch-when="date" type="date" class="form-control" ng-model="param.ngModel">
       <span ns-switch-when="enum">
         <select ns-model="param.value" class="form-control">
-          <option ng-repeat="option in param.enumOptions.split('\n')" value="{{option}}">{{option}}</option>
+          <option ng-repeat="option in extractEnumOptions(param.enumOptions)" value="{{option}}">{{option}}</option>
         </select>
       </span>
       <input ng-switch-default type="{{param.type}}" class="form-control" ng-model="param.ngModel">
diff --git a/client/app/components/parameters.js b/client/app/components/parameters.js
index 021eda44a..ca7ad00d0 100644
--- a/client/app/components/parameters.js
+++ b/client/app/components/parameters.js
@@ -40,7 +40,11 @@ function ParametersDirective($location, $uibModal) {
           });
         }, true);
       }
-
+      scope.extractEnumOptions = (enumOptions) => {
+        // These are input as newline delimited values,
+        // so we split them here.
+        return enumOptions.split('\n');
+      };
       scope.showParameterSettings = (param) => {
         $uibModal.open({
           component: 'parameterSettings',