jprdonnelly/redash
1
0
Fork 0
mirror of https://github.com/getredash/redash.git synced 2025-12-19 17:37:19 -05:00
Code Issues Projects Releases Wiki Activity

BigQuery: Remove "Job ID" metadata on annotaton to avoid cache misses (#7541)

Browse Source
This commit is contained in:
Tsuneo Yoshioka
2025-09-24 23:44:40 +09:00
committed by GitHub
parent 5e8915afe5
commit 56c06adc24
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
redash/query_runner/big_query.py
View File

@@ -156,6 +156,11 @@ class BigQuery(BaseSQLQueryRunner):
"secret": ["jsonKeyFile"], "secret": ["jsonKeyFile"],
} }
def annotate_query(self, query, metadata):
# Remove "Job ID" before annotating the query to avoid cache misses
metadata = {k: v for k, v in metadata.items() if k != "Job ID"}
return super().annotate_query(query, metadata)
def _get_bigquery_service(self): def _get_bigquery_service(self):
socket.setdefaulttimeout(settings.BIGQUERY_HTTP_TIMEOUT) socket.setdefaulttimeout(settings.BIGQUERY_HTTP_TIMEOUT)

2
tests/query_runner/test_bigquery.py
View File

@@ -20,7 +20,7 @@ class TestBigQueryQueryRunner(unittest.TestCase):
query = "SELECT a FROM tbl" query = "SELECT a FROM tbl"
expect = ( expect = (
"/* Username: username, query_id: adhoc, " "/* Username: username, query_id: adhoc, "
"Job ID: job-id, Query Hash: query-hash, " "Query Hash: query-hash, "
"Scheduled: False */ SELECT a FROM tbl" "Scheduled: False */ SELECT a FROM tbl"
) )