jprdonnelly/redash
1
0
Fork 0
mirror of https://github.com/getredash/redash.git synced 2026-03-23 13:00:10 -04:00
Code Issues Projects Releases Wiki Activity

Improved aria labels in query control dropdown

Browse Source
This commit is contained in:
Rafael Wendel
2021-02-01 18:51:03 -03:00
parent 90a321bac4
commit a18e88daa2
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
client/app/components/EditVisualizationButton/QueryControlDropdown.jsx
View File

@@ -41,6 +41,8 @@ export default function QueryControlDropdown(props) {
<Menu.Item>
<QueryResultsLink
fileType="csv"
role="menuitem"
tabIndex={0}
disabled={props.queryExecuting || !props.queryResult.getData || !props.queryResult.getData()}
query={props.query}
queryResult={props.queryResult}
@@ -52,6 +54,8 @@ export default function QueryControlDropdown(props) {
<Menu.Item>
<QueryResultsLink
fileType="tsv"
role="menuitem"
tabIndex={0}
disabled={props.queryExecuting || !props.queryResult.getData || !props.queryResult.getData()}
query={props.query}
queryResult={props.queryResult}
@@ -63,6 +67,8 @@ export default function QueryControlDropdown(props) {
<Menu.Item>
<QueryResultsLink
fileType="xlsx"
role="menuitem"
tabIndex={0}
disabled={props.queryExecuting || !props.queryResult.getData || !props.queryResult.getData()}
query={props.query}
queryResult={props.queryResult}
@@ -75,7 +81,7 @@ export default function QueryControlDropdown(props) {
);
return (
<Dropdown trigger={["click"]} overlay={menu} overlayClassName="query-control-dropdown-overlay">
<Dropdown trigger={["click"]} overlay={menu} role="menu" overlayClassName="query-control-dropdown-overlay">
<Button data-test="QueryControlDropdownButton">
<EllipsisOutlinedIcon rotate={90} />
</Button>