jprdonnelly/redash
1
0
Fork 0
mirror of https://github.com/getredash/redash.git synced 2025-12-19 17:37:19 -05:00
Code Issues Projects Releases Wiki Activity

Set is_admin of user based on ADMINS list.

Browse Source
This commit is contained in:
Arik Fraimovich
2014-03-03 11:53:49 +02:00
parent dd4c3f152a
commit af1b1c0edb
2 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
redash/authentication.py
View File

@@ -76,7 +76,8 @@ def create_and_login_user(app, openid_user):
user.save()
except models.User.DoesNotExist:
logger.debug("Creating user object (%r)", openid_user.name)
user = models.User.create(name=openid_user.name, email=openid_user.email)
user = models.User.create(name=openid_user.name, email=openid_user.email,
is_admin=(openid_user.email in settings.ADMINS))
login_user(user, remember=True)

24
tests/test_authentication.py
View File

@@ -34,13 +34,29 @@ class TestCreateAndLoginUser(BaseTestCase):
login_user_mock.assert_called_once_with(user, remember=True)
def test_creates_vaild_new_user(self):
user = ObjectDict({'email': 'test@example.com', 'name': 'Test User'})
openid_user = ObjectDict({'email': 'test@example.com', 'name': 'Test User'})
with patch.object(settings, 'GOOGLE_APPS_DOMAIN', 'example.com'), patch('redash.authentication.login_user') as login_user_mock:
create_and_login_user(None, user)
with patch.multiple(settings, GOOGLE_APPS_DOMAIN='example.com', ADMINS=['admin@example.com']), \
patch('redash.authentication.login_user') as login_user_mock:
create_and_login_user(None, openid_user)
self.assertEqual(models.User.select().count(), 1)
self.assertTrue(login_user_mock.called)
user = models.User.get(models.User.email == openid_user.email)
self.assertFalse(user.is_admin)
def test_creates_vaild_new_user_and_sets_is_admin(self):
openid_user = ObjectDict({'email': 'admin@example.com', 'name': 'Test User'})
with patch.multiple(settings, GOOGLE_APPS_DOMAIN='example.com', ADMINS=['admin@example.com']), \
patch('redash.authentication.login_user') as login_user_mock:
create_and_login_user(None, openid_user)
self.assertTrue(login_user_mock.called)
user = models.User.get(models.User.email == openid_user.email)
self.assertTrue(user.is_admin)
def test_ignores_invliad_user(self):
user = ObjectDict({'email': 'test@whatever.com'})