From b4dd9784bdcde398b733d580e55efd0b8b140efa Mon Sep 17 00:00:00 2001
From: Rafael Wendel <rafawendel2010@gmail.com>
Date: Thu, 25 Feb 2021 19:56:50 -0300
Subject: [PATCH] Removed mistakenly set menuitem role from anchors

---
 .../QueryControlDropdown.jsx                     |  7 ++-----
 client/app/components/TagsList.tsx               |  1 -
 client/app/pages/alert/components/MenuButton.jsx | 12 +++---------
 .../dashboards/components/DashboardHeader.jsx    | 16 ++++------------
 4 files changed, 9 insertions(+), 27 deletions(-)

diff --git a/client/app/components/EditVisualizationButton/QueryControlDropdown.jsx b/client/app/components/EditVisualizationButton/QueryControlDropdown.jsx
index 6f04ada37..fc5b99195 100644
--- a/client/app/components/EditVisualizationButton/QueryControlDropdown.jsx
+++ b/client/app/components/EditVisualizationButton/QueryControlDropdown.jsx
@@ -18,17 +18,14 @@ export default function QueryControlDropdown(props) {
     <Menu>
       {!props.query.isNew() && (!props.query.is_draft || !props.query.is_archived) && (
         <Menu.Item>
-          <a target="_self" role="menuitem" onClick={() => props.openAddToDashboardForm(props.selectedTab)}>
+          <a target="_self" onClick={() => props.openAddToDashboardForm(props.selectedTab)}>
             <PlusCircleFilledIcon /> Add to Dashboard
           </a>
         </Menu.Item>
       )}
       {!clientConfig.disablePublicUrls && !props.query.isNew() && (
         <Menu.Item>
-          <a
-            role="menuitem"
-            onClick={() => props.showEmbedDialog(props.query, props.selectedTab)}
-            data-test="ShowEmbedDialogButton">
+          <a onClick={() => props.showEmbedDialog(props.query, props.selectedTab)} data-test="ShowEmbedDialogButton">
             <ShareAltOutlinedIcon /> Embed Elsewhere
           </a>
         </Menu.Item>
diff --git a/client/app/components/TagsList.tsx b/client/app/components/TagsList.tsx
index 75f199cfd..7ec320f06 100644
--- a/client/app/components/TagsList.tsx
+++ b/client/app/components/TagsList.tsx
@@ -92,7 +92,6 @@ function TagsList({ tagsUrl, showUnselectAll = false, onUpdate }: TagsListProps)
             <Menu.Item key={tag.name} className="m-0">
               <a
                 className="d-flex align-items-center justify-content-between"
-                role="menuitem"
                 onClick={event => toggleTag(event, tag.name)}>
                 <span className="max-character col-xs-11">{tag.name}</span>
                 <Badge count={tag.count} />
diff --git a/client/app/pages/alert/components/MenuButton.jsx b/client/app/pages/alert/components/MenuButton.jsx
index 7897cab28..bf83f68aa 100644
--- a/client/app/pages/alert/components/MenuButton.jsx
+++ b/client/app/pages/alert/components/MenuButton.jsx
@@ -46,19 +46,13 @@ export default function MenuButton({ doDelete, canEdit, mute, unmute, muted }) {
         <Menu>
           <Menu.Item>
             {muted ? (
-              <a role="menuitem" onClick={() => execute(unmute)}>
-                Unmute Notifications
-              </a>
+              <a onClick={() => execute(unmute)}>Unmute Notifications</a>
             ) : (
-              <a role="menuitem" onClick={() => execute(mute)}>
-                Mute Notifications
-              </a>
+              <a onClick={() => execute(mute)}>Mute Notifications</a>
             )}
           </Menu.Item>
           <Menu.Item>
-            <a role="menuitem" onClick={confirmDelete}>
-              Delete
-            </a>
+            <a onClick={confirmDelete}>Delete</a>
           </Menu.Item>
         </Menu>
       }>
diff --git a/client/app/pages/dashboards/components/DashboardHeader.jsx b/client/app/pages/dashboards/components/DashboardHeader.jsx
index aadb9dfbb..be695d6d7 100644
--- a/client/app/pages/dashboards/components/DashboardHeader.jsx
+++ b/client/app/pages/dashboards/components/DashboardHeader.jsx
@@ -138,28 +138,20 @@ function DashboardMoreOptionsButton({ dashboardConfiguration }) {
       overlay={
         <Menu data-test="DashboardMoreButtonMenu">
           <Menu.Item className={cx({ hidden: gridDisabled })}>
-            <a role="menuitem" onClick={() => setEditingLayout(true)}>
-              Edit
-            </a>
+            <a onClick={() => setEditingLayout(true)}>Edit</a>
           </Menu.Item>
           {clientConfig.showPermissionsControl && isDashboardOwnerOrAdmin && (
             <Menu.Item>
-              <a role="menuitem" onClick={managePermissions}>
-                Manage Permissions
-              </a>
+              <a onClick={managePermissions}>Manage Permissions</a>
             </Menu.Item>
           )}
           {!clientConfig.disablePublish && !dashboard.is_draft && (
             <Menu.Item>
-              <a role="menuitem" onClick={togglePublished}>
-                Unpublish
-              </a>
+              <a onClick={togglePublished}>Unpublish</a>
             </Menu.Item>
           )}
           <Menu.Item>
-            <a role="menuitem" onClick={archive}>
-              Archive
-            </a>
+            <a onClick={archive}>Archive</a>
           </Menu.Item>
         </Menu>
       }>