jprdonnelly/redash
1
0
Fork 0
mirror of https://github.com/getredash/redash.git synced 2025-12-25 01:03:20 -05:00
Code Issues Projects Releases Wiki Activity

Change: close metadata database connection early in the execute query

Browse Source 
Celery task. This to prevent the task holding an idle connection for
a long period of time, while waiting for the query to finish.
This commit is contained in:
Arik Fraimovich
2018-03-08 11:06:15 +02:00
parent e1ff31718e
commit c054731794
5 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/test_models.py
View File

@@ -208,7 +208,7 @@ class QueryArchiveTest(BaseTestCase):
query = self.factory.create_query(schedule="1")
yesterday = utcnow() - datetime.timedelta(days=1)
query_result, _ = models.QueryResult.store_result(
query.org, query.data_source, query.query_hash, query.query_text,
query.org_id, query.data_source, query.query_hash, query.query_text,
"1", 123, yesterday)
query.latest_query_data = query_result
@@ -390,7 +390,7 @@ class TestQueryResultStoreResult(BaseTestCase):
def test_stores_the_result(self):
query_result, _ = models.QueryResult.store_result(
self.data_source.org, self.data_source, self.query_hash,
self.data_source.org_id, self.data_source, self.query_hash,
self.query, self.data, self.runtime, self.utcnow)
self.assertEqual(query_result.data, self.data)
@@ -406,7 +406,7 @@ class TestQueryResultStoreResult(BaseTestCase):
query3 = self.factory.create_query(query_text=self.query)
query_result, _ = models.QueryResult.store_result(
self.data_source.org, self.data_source, self.query_hash,
self.data_source.org_id, self.data_source, self.query_hash,
self.query, self.data, self.runtime, self.utcnow)
self.assertEqual(query1.latest_query_data, query_result)
@@ -419,7 +419,7 @@ class TestQueryResultStoreResult(BaseTestCase):
query3 = self.factory.create_query(query_text=self.query + "123")
query_result, _ = models.QueryResult.store_result(
self.data_source.org, self.data_source, self.query_hash,
self.data_source.org_id, self.data_source, self.query_hash,
self.query, self.data, self.runtime, self.utcnow)
self.assertEqual(query1.latest_query_data, query_result)
@@ -432,7 +432,7 @@ class TestQueryResultStoreResult(BaseTestCase):
query3 = self.factory.create_query(query_text=self.query, data_source=self.factory.create_data_source())
query_result, _ = models.QueryResult.store_result(
self.data_source.org, self.data_source, self.query_hash,
self.data_source.org_id, self.data_source, self.query_hash,
self.query, self.data, self.runtime, self.utcnow)
self.assertEqual(query1.latest_query_data, query_result)