mirror of
https://github.com/getredash/redash.git
synced 2025-12-25 01:03:20 -05:00
246eca1121
* Make core app compatible with Python 3 No backward compatibility with Python 2.7 is kept. This commit mostly contains changes made with 2to3 and manual tweaking when necessary. * Use Python 3.7 as base docker image Since it is not possible to change redash/base:debian to Python 3 without breaking future relases, its Dockerfile is temporarly copied here. * Upgrade some requirements to newest versions Some of the older versions were not compatible with Python 3. * Migrate tests to Python 3 * Build frontend on Python 3 * Make the HMAC sign function compatible with Python 3 In Python 3, HMAC only works with bytes so the strings and the float used in the sign function need to be encoded. Hopefully this is still backward compatible with already generated signatures. * Use assertCountEqual instead of assertItemsEqual The latter is not available in Python 3. See https://bugs.python.org/issue17866 * Remove redundant encoding header for Python 3 modules * Remove redundant string encoding in CLI * Rename list() functions in CLI These functions shadow the builtin list function which is problematic since 2to3 adds a fair amount of calls to the builtin list when it finds dict.keys() and dict.values(). Only the Python function is renamed, from the perspective of the CLI nothing changes. * Replace usage of Exception.message in CLI `message` is not available anymore, instead use the string representation of the exception. * Adapt test handlers to Python 3 * Fix test that relied on dict ordering * Make sure test results are always uploaded (#4215) * Support encoding memoryview to JSON psycopg2 returns `buffer` objects in Python 2.7 and `memoryview` in Python 3. See #3156 * Fix test relying on object address ordering * Decode bytes returned from Redis * Stop using e.message for most exceptions Exception.message is not available in Python 3 anymore, except for some exceptions defined by third-party libraries. * Fix writing XLSX files in Python 3 The buffer for the file should be made of bytes and the actual content written to it strings. Note: I do not know why the diff is so large as it's only a two lines change. Probably a white space or file encoding issue. * Fix test by comparing strings to strings * Fix another exception message unavailable in Python 3 * Fix export to CSV in Python 3 The UnicodeWriter is not used anymore. In Python 3, the interface provided by the CSV module only deals with strings, in and out. The encoding of the output is left to the user, in our case it is given to Flask via `make_response`. * (Python 3) Use Redis' decode_responses=True option (#4232) * Fix test_outdated_queries_works_scheduled_queries_tracker (use utcnow) * Make sure Redis connection uses decoded_responses option * Remove unused imports. * Use Redis' decode_responses option * Remove cases of explicit Redis decoding * Rename helper function and make sure it doesn't apply twice. * Don't add decode_responses to Celery Redis connection URL * Fix displaying error while connecting to SQLite The exception message is always a string in Python 3, so no need to try to decode things. * Fix another missing exception message * Handle JSON encoding for datasources returning bytes SimpleJSON assumes the bytes it receives contain text data, so it tries to UTF-8 encode them. It is sometimes not true, for instance the SQLite datasource returns bytes for BLOB types, which typically do not contain text but truly binary data. This commit disables SimpleJSON auto encoding of bytes to str and instead uses the same method as for memoryviews: generating a hex representation of the data. * Fix Python 3 compatibility with RQ * Revert some changes 2to3 tends to do (#4261) - Revert some changes 2to3 tends to do when it errs on the side of caution regarding dict view objects. - Also fixed some naming issues with one character variables in list comprehensions. - Fix Flask warning. * Upgrade dependencies * Remove useless `iter` added by 2to3 * Fix get_next_path tests (#4280) * Removed setting SERVER_NAME in tests setup to avoid a warning. * Change get_next_path to not return empty string in case of a domain only value. * Fix redirect tests: Since version 0.15 of Werkzeug it uses full path for fixing the location header instead of the root path. * Remove explicit dependency for Werkzeug * Switched pytz and certifi to unbinded versions. * Switch to new library for getting country from IP `python-geoip-geolite2` is not compatible with Python 3, instead use `maxminddb-geolite2` which is very similar as it includes the geolite2 database in the package . * Python 3 RQ modifications (#4281) * show current worker job (alongside with minor cosmetic column tweaks) * avoid loading entire job data for queued jobs * track general RQ queues (default, periodic and schemas) * get all active RQ queues * call get_celery_queues in another place * merge dicts the Python 3 way * extend the result_ttl of refresh_queries to 600 seconds to allow it to continue running periodically even after longer executions * Remove legacy Python flake8 tests
245 lines
8.0 KiB
Python
245 lines
8.0 KiB
Python
import sqlite3
|
|
from unittest import TestCase
|
|
|
|
import pytest
|
|
|
|
from redash.query_runner.query_results import (
|
|
CreateTableError, PermissionError, _load_query, create_table,
|
|
extract_cached_query_ids, extract_query_ids, fix_column_name)
|
|
from tests import BaseTestCase
|
|
|
|
|
|
class TestExtractQueryIds(TestCase):
|
|
def test_works_with_simple_query(self):
|
|
query = "SELECT 1"
|
|
self.assertEqual([], extract_query_ids(query))
|
|
|
|
def test_finds_queries_to_load(self):
|
|
query = "SELECT * FROM query_123"
|
|
self.assertEqual([123], extract_query_ids(query))
|
|
|
|
def test_finds_queries_in_joins(self):
|
|
query = "SELECT * FROM query_123 JOIN query_4566"
|
|
self.assertEqual([123, 4566], extract_query_ids(query))
|
|
|
|
def test_finds_queries_with_whitespace_characters(self):
|
|
query = "SELECT * FROM query_123 a JOIN\tquery_4566 b ON a.id=b.parent_id JOIN\r\nquery_78 c ON b.id=c.parent_id"
|
|
self.assertEqual([123, 4566, 78], extract_query_ids(query))
|
|
|
|
|
|
class TestCreateTable(TestCase):
|
|
def test_creates_table_with_colons_in_column_name(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
results = {
|
|
'columns': [{
|
|
'name': 'ga:newUsers'
|
|
}, {
|
|
'name': 'test2'
|
|
}],
|
|
'rows': [{
|
|
'ga:newUsers': 123,
|
|
'test2': 2
|
|
}]
|
|
}
|
|
table_name = 'query_123'
|
|
create_table(connection, table_name, results)
|
|
connection.execute('SELECT 1 FROM query_123')
|
|
|
|
def test_creates_table_with_double_quotes_in_column_name(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
results = {
|
|
'columns': [{
|
|
'name': 'ga:newUsers'
|
|
}, {
|
|
'name': '"test2"'
|
|
}],
|
|
'rows': [{
|
|
'ga:newUsers': 123,
|
|
'"test2"': 2
|
|
}]
|
|
}
|
|
table_name = 'query_123'
|
|
create_table(connection, table_name, results)
|
|
connection.execute('SELECT 1 FROM query_123')
|
|
|
|
def test_creates_table(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
results = {
|
|
'columns': [{
|
|
'name': 'test1'
|
|
}, {
|
|
'name': 'test2'
|
|
}],
|
|
'rows': []
|
|
}
|
|
table_name = 'query_123'
|
|
create_table(connection, table_name, results)
|
|
connection.execute('SELECT 1 FROM query_123')
|
|
|
|
def test_creates_table_with_missing_columns(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
results = {
|
|
'columns': [{
|
|
'name': 'test1'
|
|
}, {
|
|
'name': 'test2'
|
|
}],
|
|
'rows': [{
|
|
'test1': 1,
|
|
'test2': 2
|
|
}, {
|
|
'test1': 3
|
|
}]
|
|
}
|
|
table_name = 'query_123'
|
|
create_table(connection, table_name, results)
|
|
connection.execute('SELECT 1 FROM query_123')
|
|
|
|
def test_creates_table_with_spaces_in_column_name(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
results = {
|
|
'columns': [{
|
|
'name': 'two words'
|
|
}, {
|
|
'name': 'test2'
|
|
}],
|
|
'rows': [{
|
|
'two words': 1,
|
|
'test2': 2
|
|
}, {
|
|
'test1': 3
|
|
}]
|
|
}
|
|
table_name = 'query_123'
|
|
create_table(connection, table_name, results)
|
|
connection.execute('SELECT 1 FROM query_123')
|
|
|
|
def test_creates_table_with_dashes_in_column_name(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
results = {
|
|
'columns': [{
|
|
'name': 'two-words'
|
|
}, {
|
|
'name': 'test2'
|
|
}],
|
|
'rows': [{
|
|
'two-words': 1,
|
|
'test2': 2
|
|
}]
|
|
}
|
|
table_name = 'query_123'
|
|
create_table(connection, table_name, results)
|
|
connection.execute('SELECT 1 FROM query_123')
|
|
connection.execute('SELECT "two-words" FROM query_123')
|
|
|
|
def test_creates_table_with_non_ascii_in_column_name(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
results = {
|
|
'columns': [{
|
|
'name': '\xe4'
|
|
}, {
|
|
'name': 'test2'
|
|
}],
|
|
'rows': [{
|
|
'\xe4': 1,
|
|
'test2': 2
|
|
}]
|
|
}
|
|
table_name = 'query_123'
|
|
create_table(connection, table_name, results)
|
|
connection.execute('SELECT 1 FROM query_123')
|
|
|
|
def test_shows_meaningful_error_on_failure_to_create_table(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
results = {'columns': [], 'rows': []}
|
|
table_name = 'query_123'
|
|
with pytest.raises(CreateTableError):
|
|
create_table(connection, table_name, results)
|
|
|
|
def test_loads_results(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
rows = [{'test1': 1, 'test2': 'test'}, {'test1': 2, 'test2': 'test2'}]
|
|
results = {
|
|
'columns': [{
|
|
'name': 'test1'
|
|
}, {
|
|
'name': 'test2'
|
|
}],
|
|
'rows': rows
|
|
}
|
|
table_name = 'query_123'
|
|
create_table(connection, table_name, results)
|
|
self.assertEqual(
|
|
len(list(connection.execute('SELECT * FROM query_123'))), 2)
|
|
|
|
def test_loads_list_and_dict_results(self):
|
|
connection = sqlite3.connect(':memory:')
|
|
rows = [{'test1': [1, 2, 3]}, {'test2': {'a': 'b'}}]
|
|
results = {
|
|
'columns': [{
|
|
'name': 'test1'
|
|
}, {
|
|
'name': 'test2'
|
|
}],
|
|
'rows': rows
|
|
}
|
|
table_name = 'query_123'
|
|
create_table(connection, table_name, results)
|
|
self.assertEqual(
|
|
len(list(connection.execute('SELECT * FROM query_123'))), 2)
|
|
|
|
|
|
class TestGetQuery(BaseTestCase):
|
|
# test query from different account
|
|
def test_raises_exception_for_query_from_different_account(self):
|
|
query = self.factory.create_query()
|
|
user = self.factory.create_user(org=self.factory.create_org())
|
|
|
|
self.assertRaises(PermissionError, lambda: _load_query(user, query.id))
|
|
|
|
def test_raises_exception_for_query_with_different_groups(self):
|
|
ds = self.factory.create_data_source(group=self.factory.create_group())
|
|
query = self.factory.create_query(data_source=ds)
|
|
user = self.factory.create_user()
|
|
|
|
self.assertRaises(PermissionError, lambda: _load_query(user, query.id))
|
|
|
|
def test_returns_query(self):
|
|
query = self.factory.create_query()
|
|
user = self.factory.create_user()
|
|
|
|
loaded = _load_query(user, query.id)
|
|
self.assertEqual(query, loaded)
|
|
|
|
def test_returns_query_when_user_has_view_only_access(self):
|
|
ds = self.factory.create_data_source(
|
|
group=self.factory.org.default_group, view_only=True)
|
|
query = self.factory.create_query(data_source=ds)
|
|
user = self.factory.create_user()
|
|
|
|
loaded = _load_query(user, query.id)
|
|
self.assertEqual(query, loaded)
|
|
|
|
|
|
class TestExtractCachedQueryIds(TestCase):
|
|
def test_works_with_simple_query(self):
|
|
query = "SELECT 1"
|
|
self.assertEqual([], extract_cached_query_ids(query))
|
|
|
|
def test_finds_queries_to_load(self):
|
|
query = "SELECT * FROM cached_query_123"
|
|
self.assertEqual([123], extract_cached_query_ids(query))
|
|
|
|
def test_finds_queries_in_joins(self):
|
|
query = "SELECT * FROM cached_query_123 JOIN cached_query_4566"
|
|
self.assertEqual([123, 4566], extract_cached_query_ids(query))
|
|
|
|
def test_finds_queries_with_whitespace_characters(self):
|
|
query = "SELECT * FROM cached_query_123 a JOIN\tcached_query_4566 b ON a.id=b.parent_id JOIN\r\ncached_query_78 c ON b.id=c.parent_id"
|
|
self.assertEqual([123, 4566, 78], extract_cached_query_ids(query))
|
|
|
|
|
|
class TestFixColumnName(TestCase):
|
|
def test_fix_column_name(self):
|
|
self.assertEqual('"a_b_c_d"', fix_column_name("a:b.c d"))
|