mirror of
https://github.com/getredash/redash.git
synced 2026-03-23 04:00:09 -04:00
* Migrate router and <app-view> to React: skeleton * Update layout on route change * Start moving page routes from angular to react * Move page routes to react except of public dashboard and visualization embed) * Move public dashboard and visualization embed routes to React * Replace $route/$routeParams usages * Some cleanup * Replace AngularJS $location service with implementation based on history library * Minor fix to how ApplicationView handles route change * Explicitly use global layout for each page instead of handling related stuff in ApplicationArea component * Error handling * Remove AngularJS and related dependencies * Move Parameter factory method to a separate file * Fix CSS (replace custom components with classes) * Fix: keep other url parts when updating location partially; refine code * Fix tests * Make router work in multi-org mode (respect <base> tag) * Optimzation: don't resolve route if path didn't change * Fix search input in header; error handling improvement (handle more errors in pages; global error handler for unhandled errors; dialog dismiss 'unhandled rejection' errors) * Fix page keys; fix navigateTo calls (third parameter not available) * Use relative links * Router: ignore location REPLACE events, resolve only on PUSH/POP * Fix tests * Remove unused jQuery reference * Show error from backend when creating Destination * Remove route.resolve where not necessary (used constant values) * New Query page: keep state on saving, reload when creating another new query * Use currentRoute.key instead of hard-coded keys for page components * Tidy up Router * Tidy up location service * Fix tests * Don't add parameters changes to browser's history * Fix test (improved fix) Co-authored-by: Gabriel Dutra <nesk.frz@gmail.com>
41 lines
1.1 KiB
JavaScript
41 lines
1.1 KiB
JavaScript
import React from "react";
|
|
import PropTypes from "prop-types";
|
|
|
|
export default class FavoritesControl extends React.Component {
|
|
static propTypes = {
|
|
item: PropTypes.shape({
|
|
is_favorite: PropTypes.bool.isRequired,
|
|
}).isRequired,
|
|
onChange: PropTypes.func,
|
|
};
|
|
|
|
static defaultProps = {
|
|
onChange: () => {},
|
|
};
|
|
|
|
toggleItem(event, item, callback) {
|
|
const action = item.is_favorite ? item.unfavorite.bind(item) : item.favorite.bind(item);
|
|
const savedIsFavorite = item.is_favorite;
|
|
|
|
action().then(() => {
|
|
item.is_favorite = !savedIsFavorite;
|
|
this.forceUpdate();
|
|
callback();
|
|
});
|
|
}
|
|
|
|
render() {
|
|
const { item, onChange } = this.props;
|
|
const icon = item.is_favorite ? "fa fa-star" : "fa fa-star-o";
|
|
const title = item.is_favorite ? "Remove from favorites" : "Add to favorites";
|
|
return (
|
|
<a
|
|
title={title}
|
|
className="favorites-control btn-favourite"
|
|
onClick={event => this.toggleItem(event, item, onChange)}>
|
|
<i className={icon} aria-hidden="true" />
|
|
</a>
|
|
);
|
|
}
|
|
}
|