mirror of
https://github.com/getredash/redash.git
synced 2026-03-22 10:00:17 -04:00
* Migrate router and <app-view> to React: skeleton * Update layout on route change * Start moving page routes from angular to react * Move page routes to react except of public dashboard and visualization embed) * Move public dashboard and visualization embed routes to React * Replace $route/$routeParams usages * Some cleanup * Replace AngularJS $location service with implementation based on history library * Minor fix to how ApplicationView handles route change * Explicitly use global layout for each page instead of handling related stuff in ApplicationArea component * Error handling * Remove AngularJS and related dependencies * Move Parameter factory method to a separate file * Fix CSS (replace custom components with classes) * Fix: keep other url parts when updating location partially; refine code * Fix tests * Make router work in multi-org mode (respect <base> tag) * Optimzation: don't resolve route if path didn't change * Fix search input in header; error handling improvement (handle more errors in pages; global error handler for unhandled errors; dialog dismiss 'unhandled rejection' errors) * Fix page keys; fix navigateTo calls (third parameter not available) * Use relative links * Router: ignore location REPLACE events, resolve only on PUSH/POP * Fix tests * Remove unused jQuery reference * Show error from backend when creating Destination * Remove route.resolve where not necessary (used constant values) * New Query page: keep state on saving, reload when creating another new query * Use currentRoute.key instead of hard-coded keys for page components * Tidy up Router * Tidy up location service * Fix tests * Don't add parameters changes to browser's history * Fix test (improved fix) Co-authored-by: Gabriel Dutra <nesk.frz@gmail.com>
179 lines
5.7 KiB
JavaScript
179 lines
5.7 KiB
JavaScript
import { size, filter, forEach, extend } from "lodash";
|
|
import React from "react";
|
|
import PropTypes from "prop-types";
|
|
import { SortableContainer, SortableElement, DragHandle } from "@/components/sortable";
|
|
import location from "@/services/location";
|
|
import { Parameter, createParameter } from "@/services/parameters";
|
|
import ParameterApplyButton from "@/components/ParameterApplyButton";
|
|
import ParameterValueInput from "@/components/ParameterValueInput";
|
|
import EditParameterSettingsDialog from "./EditParameterSettingsDialog";
|
|
import { toHuman } from "@/lib/utils";
|
|
|
|
import "./Parameters.less";
|
|
|
|
function updateUrl(parameters) {
|
|
const params = extend({}, location.search);
|
|
parameters.forEach(param => {
|
|
extend(params, param.toUrlParams());
|
|
});
|
|
location.setSearch(params, true);
|
|
}
|
|
|
|
export default class Parameters extends React.Component {
|
|
static propTypes = {
|
|
parameters: PropTypes.arrayOf(PropTypes.instanceOf(Parameter)),
|
|
editable: PropTypes.bool,
|
|
disableUrlUpdate: PropTypes.bool,
|
|
onValuesChange: PropTypes.func,
|
|
onPendingValuesChange: PropTypes.func,
|
|
onParametersEdit: PropTypes.func,
|
|
};
|
|
|
|
static defaultProps = {
|
|
parameters: [],
|
|
editable: false,
|
|
disableUrlUpdate: false,
|
|
onValuesChange: () => {},
|
|
onPendingValuesChange: () => {},
|
|
onParametersEdit: () => {},
|
|
};
|
|
|
|
constructor(props) {
|
|
super(props);
|
|
const { parameters } = props;
|
|
this.state = { parameters };
|
|
if (!props.disableUrlUpdate) {
|
|
updateUrl(parameters);
|
|
}
|
|
}
|
|
|
|
componentDidUpdate = prevProps => {
|
|
const { parameters, disableUrlUpdate } = this.props;
|
|
const parametersChanged = prevProps.parameters !== parameters;
|
|
const disableUrlUpdateChanged = prevProps.disableUrlUpdate !== disableUrlUpdate;
|
|
if (parametersChanged) {
|
|
this.setState({ parameters });
|
|
}
|
|
if ((parametersChanged || disableUrlUpdateChanged) && !disableUrlUpdate) {
|
|
updateUrl(parameters);
|
|
}
|
|
};
|
|
|
|
handleKeyDown = e => {
|
|
// Cmd/Ctrl/Alt + Enter
|
|
if (e.keyCode === 13 && (e.ctrlKey || e.metaKey || e.altKey)) {
|
|
e.stopPropagation();
|
|
this.applyChanges();
|
|
}
|
|
};
|
|
|
|
setPendingValue = (param, value, isDirty) => {
|
|
const { onPendingValuesChange } = this.props;
|
|
this.setState(({ parameters }) => {
|
|
if (isDirty) {
|
|
param.setPendingValue(value);
|
|
} else {
|
|
param.clearPendingValue();
|
|
}
|
|
onPendingValuesChange();
|
|
return { parameters };
|
|
});
|
|
};
|
|
|
|
moveParameter = ({ oldIndex, newIndex }) => {
|
|
const { onParametersEdit } = this.props;
|
|
if (oldIndex !== newIndex) {
|
|
this.setState(({ parameters }) => {
|
|
parameters.splice(newIndex, 0, parameters.splice(oldIndex, 1)[0]);
|
|
onParametersEdit();
|
|
return { parameters };
|
|
});
|
|
}
|
|
};
|
|
|
|
applyChanges = () => {
|
|
const { onValuesChange, disableUrlUpdate } = this.props;
|
|
this.setState(({ parameters }) => {
|
|
const parametersWithPendingValues = parameters.filter(p => p.hasPendingValue);
|
|
forEach(parameters, p => p.applyPendingValue());
|
|
if (!disableUrlUpdate) {
|
|
updateUrl(parameters);
|
|
}
|
|
onValuesChange(parametersWithPendingValues);
|
|
return { parameters };
|
|
});
|
|
};
|
|
|
|
showParameterSettings = (parameter, index) => {
|
|
const { onParametersEdit } = this.props;
|
|
EditParameterSettingsDialog.showModal({ parameter })
|
|
.result.then(updated => {
|
|
this.setState(({ parameters }) => {
|
|
const updatedParameter = extend(parameter, updated);
|
|
parameters[index] = createParameter(updatedParameter, updatedParameter.parentQueryId);
|
|
onParametersEdit();
|
|
return { parameters };
|
|
});
|
|
})
|
|
.catch(() => {}); // ignore dismiss
|
|
};
|
|
|
|
renderParameter(param, index) {
|
|
const { editable } = this.props;
|
|
return (
|
|
<div key={param.name} className="di-block" data-test={`ParameterName-${param.name}`}>
|
|
<div className="parameter-heading">
|
|
<label>{param.title || toHuman(param.name)}</label>
|
|
{editable && (
|
|
<button
|
|
className="btn btn-default btn-xs m-l-5"
|
|
onClick={() => this.showParameterSettings(param, index)}
|
|
data-test={`ParameterSettings-${param.name}`}
|
|
type="button">
|
|
<i className="fa fa-cog" />
|
|
</button>
|
|
)}
|
|
</div>
|
|
<ParameterValueInput
|
|
type={param.type}
|
|
value={param.normalizedValue}
|
|
parameter={param}
|
|
enumOptions={param.enumOptions}
|
|
queryId={param.queryId}
|
|
onSelect={(value, isDirty) => this.setPendingValue(param, value, isDirty)}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
render() {
|
|
const { parameters } = this.state;
|
|
const { editable } = this.props;
|
|
const dirtyParamCount = size(filter(parameters, "hasPendingValue"));
|
|
return (
|
|
<SortableContainer
|
|
disabled={!editable}
|
|
axis="xy"
|
|
useDragHandle
|
|
lockToContainerEdges
|
|
helperClass="parameter-dragged"
|
|
updateBeforeSortStart={this.onBeforeSortStart}
|
|
onSortEnd={this.moveParameter}
|
|
containerProps={{
|
|
className: "parameter-container",
|
|
onKeyDown: dirtyParamCount ? this.handleKeyDown : null,
|
|
}}>
|
|
{parameters.map((param, index) => (
|
|
<SortableElement key={param.name} index={index}>
|
|
<div className="parameter-block" data-editable={editable || null}>
|
|
{editable && <DragHandle data-test={`DragHandle-${param.name}`} />}
|
|
{this.renderParameter(param, index)}
|
|
</div>
|
|
</SortableElement>
|
|
))}
|
|
<ParameterApplyButton onClick={this.applyChanges} paramCount={dirtyParamCount} />
|
|
</SortableContainer>
|
|
);
|
|
}
|
|
}
|