From f85c76b139bb2ebc8ad84ae11f825e9dd05ad32a Mon Sep 17 00:00:00 2001 From: kai Date: Thu, 10 Mar 2022 16:05:00 +0000 Subject: [PATCH] Update plugin manager to remove plugin from map if startup fails. Prevents timeout when retrying to start a failed plugin. Closes #1631 --- pluginmanager/plugin_manager.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pluginmanager/plugin_manager.go b/pluginmanager/plugin_manager.go index 3b8429dfe..c0877db77 100644 --- a/pluginmanager/plugin_manager.go +++ b/pluginmanager/plugin_manager.go @@ -164,6 +164,10 @@ func (m *PluginManager) getPlugin(connection string) (_ *pb.ReattachConfig, err // so we need to start the plugin client, err := m.startPlugin(connection) if err != nil { + m.mut.Lock() + delete(m.Plugins, connection) + m.mut.Unlock() + log.Println("[TRACE] startPlugin failed with", err) return nil, err }