From 78ca72202808b91e1882dfb4abf8da35cf19b99c Mon Sep 17 00:00:00 2001 From: Leonard Hecker Date: Fri, 19 Jun 2020 00:09:45 +0200 Subject: [PATCH] Fixed #6377: TerminalCore::_altGrAliasing is undefined by default (#6571) ## Summary of the Pull Request Fixes #6377. `TerminalCore` does not initialize `_altGrAliasing`. The impact is minimized in WT because it defaults to `true` in higher layers. It's not initialized when WPF is driving. ## PR Checklist * [x] Closes #6377 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx --- src/cascadia/TerminalCore/Terminal.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cascadia/TerminalCore/Terminal.cpp b/src/cascadia/TerminalCore/Terminal.cpp index 370ec3e78a..b12e07628d 100644 --- a/src/cascadia/TerminalCore/Terminal.cpp +++ b/src/cascadia/TerminalCore/Terminal.cpp @@ -44,6 +44,7 @@ Terminal::Terminal() : _pfnWriteInput{ nullptr }, _scrollOffset{ 0 }, _snapOnInput{ true }, + _altGrAliasing{ true }, _blockSelection{ false }, _selection{ std::nullopt } {